Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issue 11451017: Make the unittest framework more robust wrt asynchronous tests. (Closed)

Created:
8 years ago by floitsch
Modified:
8 years ago
Reviewers:
Bob Nystrom, gram, siva
CC:
reviews_dartlang.org, Bob Nystrom
Visibility:
Public.

Description

Make the unittest framework more robust wrt asynchronous tests. Committed: https://code.google.com/p/dart/source/detail?r=15755

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M pkg/unittest/lib/src/config.dart View 4 chunks +7 lines, -1 line 3 comments Download

Messages

Total messages: 5 (0 generated)
floitsch
https://codereview.chromium.org/11451017/diff/1/pkg/unittest/lib/src/config.dart File pkg/unittest/lib/src/config.dart (right): https://codereview.chromium.org/11451017/diff/1/pkg/unittest/lib/src/config.dart#newcode103 pkg/unittest/lib/src/config.dart:103: var resultString = "${t.result}".toUpperCase(); I got null-pointer exceptions on ...
8 years ago (2012-12-05 19:39:50 UTC) #1
Bob Nystrom
Adding Gram and taking myself off. The change looks fine to me, but it's been ...
8 years ago (2012-12-05 21:21:54 UTC) #2
gram
lgtm
8 years ago (2012-12-05 21:39:04 UTC) #3
siva
https://codereview.chromium.org/11451017/diff/1/pkg/unittest/lib/src/config.dart File pkg/unittest/lib/src/config.dart (right): https://codereview.chromium.org/11451017/diff/1/pkg/unittest/lib/src/config.dart#newcode136 pkg/unittest/lib/src/config.dart:136: throw new Exception('Some tests failed.'); The _receivePort should be ...
8 years ago (2012-12-20 21:27:20 UTC) #4
floitsch
8 years ago (2012-12-21 08:25:42 UTC) #5
Message was sent while issue was closed.
https://codereview.chromium.org/11451017/diff/1/pkg/unittest/lib/src/config.dart
File pkg/unittest/lib/src/config.dart (right):

https://codereview.chromium.org/11451017/diff/1/pkg/unittest/lib/src/config.d...
pkg/unittest/lib/src/config.dart:136: throw new Exception('Some tests failed.');
On 2012/12/20 21:27:20, siva wrote:
> The _receivePort should be closed on the exception path too?

https://codereview.chromium.org/11570065
thanks.

Powered by Google App Engine
This is Rietveld 408576698