Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(878)

Unified Diff: scripts/slave/extract_build.py

Issue 11451004: Bugfixing URL construction for extract build step (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Rebased Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/slave_utils.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/extract_build.py
diff --git a/scripts/slave/extract_build.py b/scripts/slave/extract_build.py
index f08fba727d374df40ece3e539995cdb16a0caf88..2328d808924a7f1c1fa63d87065b32586d150705 100755
--- a/scripts/slave/extract_build.py
+++ b/scripts/slave/extract_build.py
@@ -77,15 +77,17 @@ def GetBuildUrl(abs_build_dir, options):
replace_dict = dict(options.build_properties)
# If builddir isn't specified, assume buildbot used the builder name
# as the root folder for the build.
- if not replace_dict.get('parent_builddir'):
- replace_dict['parent_builddir'] = replace_dict['parentname']
+ if not replace_dict.get('parent_builddir') and replace_dict.get('parentname'):
+ replace_dict['parent_builddir'] = replace_dict.get('parentname', '')
replace_dict['base_filename'] = base_filename
url = options.build_url or options.factory_properties.get('build_url')
if not url:
url = ('http://%(parentslavename)s/b/build/slave/%(parent_builddir)s/'
'chrome_staging')
if url[-4:] != '.zip': # assume filename not specified
- url = os.path.join(url, '%(base_filename)s.zip')
+ # Append the filename to the base URL. First strip any trailing slashes.
+ url = url.rstrip('/')
+ url = '%s/%s' % (url, '%(base_filename)s.zip')
url = url % replace_dict
versioned_url = url.replace('.zip', version_suffix + '.zip')
« no previous file with comments | « no previous file | scripts/slave/slave_utils.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698