Focus launcher if spoken feedback is enabled and no other windows visible.

ash/wm/ash_activation_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/wm/ash_activation_controller.h"
 
+#include "ash/launcher/launcher.h"
 #include "ash/root_window_controller.h"
 #include "ash/shell.h"
+#include "ash/shell_delegate.h"
 #include "ash/wm/activation_controller.h"
 #include "ash/wm/property_util.h"
 #include "ash/wm/window_util.h"
 #include "ash/wm/workspace_controller.h"
 #include "ui/views/corewm/window_modality_controller.h"
+#include "ui/views/widget/widget.h"
 
 namespace ash {
 namespace internal {
 
 ////////////////////////////////////////////////////////////////////////////////
 // AshActivationController, public:
 
 AshActivationController::AshActivationController() {
 }
 
 AshActivationController::~AshActivationController() {
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // AshActivationController, ActivationControllerDelegate implementation:
 
 aura::Window* AshActivationController::WillActivateWindow(
     aura::Window* window) {
   aura::Window* window_modal_transient =
       views::corewm::GetModalTransient(window);
   if (window_modal_transient)
     return window_modal_transient;
 
+  // We want to allow to activate launcher only when invoked by focus cycler
+  // or as a fallback while Spoken feedback is enabled and no other windows
+  // on the screen are activeable.
+  Launcher* launcher;

[sky, 2012/12/05 05:01:09]

Can we do all this if window is null and move to a separate function. I'm
thinking:

if (!window)
  window = PrepareToActivateLauncher();

Where PrepareToActivateLauncher() is all the code you have here. Also, I thought
you only wanted to do this if spoken feedback is enabled.

[mtomasz, 2012/12/07 06:18:47]

Done.

+  if (Shell::IsLauncherPerDisplayEnabled()) {
+    launcher = GetRootWindowController(
+        Shell::GetActiveRootWindow())->launcher();
+  } else {
+    launcher = Launcher::ForPrimaryDisplay();
+  }
+  if (launcher) {
+    aura::Window* launcher_window = launcher->widget()->GetNativeWindow();
+    if (window == NULL) {
+      // Fallback to launcher when Spoken feedback is enabled.
+      launcher->WillActivateAsFallback();
+      window = launcher_window;
+    }
+  }
+
   // Make sure the workspace manager switches to the workspace for window.
   // Without this CanReceiveEvents() below returns false and activation never
   // changes. CanReceiveEvents() returns false if |window| isn't in the active
   // workspace, in which case its parent is not visible.
   // TODO(sky): if I instead change the opacity of the parent this isn't an
   // issue, but will make animations trickier... Consider which one is better.
   if (window) {
     internal::RootWindowController* root_window_controller =
         GetRootWindowController(window->GetRootWindow());
     root_window_controller->workspace_controller()->
@@ skipping 25 matching lines @@
     aura::Window* window) {
   aura::Window* window_modal_transient =
       views::corewm::GetModalTransient(window);
   if (window_modal_transient)
     return window_modal_transient;
   return window;
 }
 
 }  // namespace internal
 }  // namespace ash