Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 1145073002: Move AddressSanitizer.h to wtf/ (Closed)

Created:
5 years, 7 months ago by sof
Modified:
5 years, 7 months ago
CC:
blink-reviews, arv+blink, vivekg_samsung, vivekg, blink-reviews-bindings_chromium.org, blink-reviews-wtf_chromium.org, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move AddressSanitizer.h to wtf/ ASan (no) annotation helper macros are useful outside of Oilpan, including WTF, hence move it to there. R=haraken,tkent Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195676

Patch Set 1 #

Patch Set 2 : fix non-Oilpan compilation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -105 lines) Patch
M Source/bindings/core/v8/V8Initializer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/ThreadTimers.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/Timer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/Timer.cpp View 1 chunk +0 lines, -1 line 0 comments Download
D Source/platform/heap/AddressSanitizer.h View 1 1 chunk +0 lines, -73 lines 0 comments Download
M Source/platform/heap/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/heap/Heap.h View 2 chunks +7 lines, -1 line 0 comments Download
M Source/platform/heap/ThreadState.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/heap/ThreadState.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/heap/blink_heap.gypi View 1 chunk +0 lines, -1 line 0 comments Download
A Source/wtf/AddressSanitizer.h View 1 1 chunk +43 lines, -0 lines 0 comments Download
M Source/wtf/Atomics.h View 2 chunks +3 lines, -11 lines 0 comments Download
M Source/wtf/LinkedHashSet.h View 2 chunks +2 lines, -12 lines 0 comments Download
M Source/wtf/wtf.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sof
please take a look. Following up on https://codereview.chromium.org/1120943002/#msg15
5 years, 7 months ago (2015-05-20 10:43:21 UTC) #2
haraken
LGTM
5 years, 7 months ago (2015-05-20 12:25:33 UTC) #3
tkent
lgtm
5 years, 7 months ago (2015-05-20 23:33:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145073002/20001
5 years, 7 months ago (2015-05-21 05:06:36 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-21 06:37:25 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195676

Powered by Google App Engine
This is Rietveld 408576698