Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Unified Diff: runtime/vm/stub_code_x64.cc

Issue 1145063003: Do not emit debug check in optimized IC stubs (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/vm/stub_code_mips.cc ('K') | « runtime/vm/stub_code_mips.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/stub_code_x64.cc
diff --git a/runtime/vm/stub_code_x64.cc b/runtime/vm/stub_code_x64.cc
index 6ae08ecf3075e6f0a9a2a35fbed57487e1fe0d2d..5a438b02da296ca5b94b02a3a700a5c7d0a3ce5d 100644
--- a/runtime/vm/stub_code_x64.cc
+++ b/runtime/vm/stub_code_x64.cc
@@ -1334,7 +1334,8 @@ void StubCode::GenerateNArgsCheckInlineCacheStub(
intptr_t num_args,
const RuntimeEntry& handle_ic_miss,
Token::Kind kind,
- RangeCollectionMode range_collection_mode) {
+ RangeCollectionMode range_collection_mode,
+ bool optimized) {
ASSERT(num_args > 0);
#if defined(DEBUG)
{ Label ok;
@@ -1351,7 +1352,7 @@ void StubCode::GenerateNArgsCheckInlineCacheStub(
#endif // DEBUG
Label stepping, done_stepping;
- if (FLAG_support_debugger) {
+ if (FLAG_support_debugger && !optimized) {
__ Comment("Check single stepping");
__ LoadIsolate(RAX);
__ cmpb(Address(RAX, Isolate::single_step_offset()), Immediate(0));
@@ -1511,7 +1512,7 @@ void StubCode::GenerateNArgsCheckInlineCacheStub(
__ jmp(RCX);
}
- if (FLAG_support_debugger) {
+ if (FLAG_support_debugger && !optimized) {
__ Bind(&stepping);
__ EnterStubFrame();
__ pushq(RBX);
@@ -1615,7 +1616,7 @@ void StubCode::GenerateOneArgOptimizedCheckInlineCacheStub(
GenerateNArgsCheckInlineCacheStub(assembler, 1,
kInlineCacheMissHandlerOneArgRuntimeEntry,
Token::kILLEGAL,
- kIgnoreRanges);
+ kIgnoreRanges, true);
}
@@ -1625,7 +1626,7 @@ void StubCode::GenerateTwoArgsOptimizedCheckInlineCacheStub(
GenerateNArgsCheckInlineCacheStub(assembler, 2,
kInlineCacheMissHandlerTwoArgsRuntimeEntry,
Token::kILLEGAL,
- kIgnoreRanges);
+ kIgnoreRanges, true);
}
« runtime/vm/stub_code_mips.cc ('K') | « runtime/vm/stub_code_mips.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698