Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Unified Diff: runtime/vm/stub_code_arm64.cc

Issue 1145063003: Do not emit debug check in optimized IC stubs (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/stub_code_arm64.cc
diff --git a/runtime/vm/stub_code_arm64.cc b/runtime/vm/stub_code_arm64.cc
index e443039ff3fbb3037bf44661edcb49147c505279..2d88a2c9150a35d68133b6ccf7c3e5f320c6dd08 100644
--- a/runtime/vm/stub_code_arm64.cc
+++ b/runtime/vm/stub_code_arm64.cc
@@ -1380,7 +1380,8 @@ void StubCode::GenerateNArgsCheckInlineCacheStub(
intptr_t num_args,
const RuntimeEntry& handle_ic_miss,
Token::Kind kind,
- RangeCollectionMode range_collection_mode) {
+ RangeCollectionMode range_collection_mode,
+ bool optimized) {
ASSERT(num_args > 0);
#if defined(DEBUG)
{ Label ok;
@@ -1398,7 +1399,7 @@ void StubCode::GenerateNArgsCheckInlineCacheStub(
#endif // DEBUG
Label stepping, done_stepping;
- if (FLAG_support_debugger) {
+ if (FLAG_support_debugger && !optimized) {
__ Comment("Check single stepping");
__ LoadIsolate(R6, kNoPP);
__ LoadFromOffset(
@@ -1570,7 +1571,7 @@ void StubCode::GenerateNArgsCheckInlineCacheStub(
__ br(R2);
}
- if (FLAG_support_debugger) {
+ if (FLAG_support_debugger && !optimized) {
__ Bind(&stepping);
__ EnterStubFrame();
__ Push(R5); // Preserve IC data.
@@ -1657,7 +1658,7 @@ void StubCode::GenerateOneArgOptimizedCheckInlineCacheStub(
GenerateOptimizedUsageCounterIncrement(assembler);
GenerateNArgsCheckInlineCacheStub(assembler, 1,
kInlineCacheMissHandlerOneArgRuntimeEntry, Token::kILLEGAL,
- kIgnoreRanges);
+ kIgnoreRanges, true);
}
@@ -1666,7 +1667,7 @@ void StubCode::GenerateTwoArgsOptimizedCheckInlineCacheStub(
GenerateOptimizedUsageCounterIncrement(assembler);
GenerateNArgsCheckInlineCacheStub(assembler, 2,
kInlineCacheMissHandlerTwoArgsRuntimeEntry, Token::kILLEGAL,
- kIgnoreRanges);
+ kIgnoreRanges, true);
}

Powered by Google App Engine
This is Rietveld 408576698