Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1145063002: Update ReturnValue to take non-deprecated versions of handles (Closed)

Created:
5 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 7 months ago
Reviewers:
vogelheim
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Update ReturnValue to take non-deprecated versions of handles R=vogelheim@chromium.org BUG=none LOG=n Committed: https://crrev.com/bf032c2ec8d4858e6cba4ccaf63200f7f39c7cd8 Cr-Commit-Position: refs/heads/master@{#28501}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -5 lines) Patch
M include/v8.h View 3 chunks +24 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
jochen (gone - plz use gerrit)
5 years, 7 months ago (2015-05-20 08:33:14 UTC) #1
vogelheim
lgtm
5 years, 7 months ago (2015-05-20 08:56:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145063002/1
5 years, 7 months ago (2015-05-20 08:58:17 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-20 08:59:49 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 09:00:11 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bf032c2ec8d4858e6cba4ccaf63200f7f39c7cd8
Cr-Commit-Position: refs/heads/master@{#28501}

Powered by Google App Engine
This is Rietveld 408576698