Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(702)

Unified Diff: runtime/observatory/tests/service/test_helper.dart

Issue 1145053004: Revert "Per-closure breakpoints; restructure breakpoint implementation to keep a list of conditions… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/tests/service/break_on_activation_test.dart ('k') | runtime/vm/debugger.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/tests/service/test_helper.dart
diff --git a/runtime/observatory/tests/service/test_helper.dart b/runtime/observatory/tests/service/test_helper.dart
index fed6ee1c609f27016a11ab13f2b4920fb407a5e0..6da69becfc01f52b5f273e55768acc87ae72a345 100644
--- a/runtime/observatory/tests/service/test_helper.dart
+++ b/runtime/observatory/tests/service/test_helper.dart
@@ -108,9 +108,6 @@ void runIsolateTests(List<String> mainArgs,
} else {
var process = new _TestLauncher();
process.launch(pause_on_exit).then((port) {
- if (mainArgs.contains("--gdb")) {
- port = 8181;
- }
String addr = 'ws://localhost:$port/ws';
var testIndex = 1;
var totalTests = tests.length;
@@ -195,9 +192,6 @@ Future runVMTests(List<String> mainArgs,
} else {
var process = new _TestLauncher();
process.launch(pause_on_exit).then((port) async {
- if (mainArgs.contains("--gdb")) {
- port = 8181;
- }
String addr = 'ws://localhost:$port/ws';
var testIndex = 1;
var totalTests = tests.length;
« no previous file with comments | « runtime/observatory/tests/service/break_on_activation_test.dart ('k') | runtime/vm/debugger.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698