Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Side by Side Diff: runtime/vm/json_stream.cc

Issue 1145053004: Revert "Per-closure breakpoints; restructure breakpoint implementation to keep a list of conditions… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/json_stream.h ('k') | runtime/vm/object_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "platform/assert.h" 5 #include "platform/assert.h"
6 6
7 #include "vm/dart_entry.h" 7 #include "vm/dart_entry.h"
8 #include "vm/debugger.h" 8 #include "vm/debugger.h"
9 #include "vm/json_stream.h" 9 #include "vm/json_stream.h"
10 #include "vm/message.h" 10 #include "vm/message.h"
(...skipping 309 matching lines...) Expand 10 before | Expand all | Expand 10 after
320 free(p); 320 free(p);
321 } 321 }
322 322
323 323
324 void JSONStream::PrintValue(const Object& o, bool ref) { 324 void JSONStream::PrintValue(const Object& o, bool ref) {
325 PrintCommaIfNeeded(); 325 PrintCommaIfNeeded();
326 o.PrintJSON(this, ref); 326 o.PrintJSON(this, ref);
327 } 327 }
328 328
329 329
330 void JSONStream::PrintValue(Breakpoint* bpt) { 330 void JSONStream::PrintValue(SourceBreakpoint* bpt) {
331 PrintCommaIfNeeded(); 331 PrintCommaIfNeeded();
332 bpt->PrintJSON(this); 332 bpt->PrintJSON(this);
333 } 333 }
334 334
335 335
336 void JSONStream::PrintValue(const ServiceEvent* event) { 336 void JSONStream::PrintValue(const ServiceEvent* event) {
337 PrintCommaIfNeeded(); 337 PrintCommaIfNeeded();
338 event->PrintJSON(this); 338 event->PrintJSON(this);
339 } 339 }
340 340
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
408 PrintValueNoEscape(s); 408 PrintValueNoEscape(s);
409 } 409 }
410 410
411 411
412 void JSONStream::PrintProperty(const char* name, const ServiceEvent* event) { 412 void JSONStream::PrintProperty(const char* name, const ServiceEvent* event) {
413 PrintPropertyName(name); 413 PrintPropertyName(name);
414 PrintValue(event); 414 PrintValue(event);
415 } 415 }
416 416
417 417
418 void JSONStream::PrintProperty(const char* name, Breakpoint* bpt) { 418 void JSONStream::PrintProperty(const char* name, SourceBreakpoint* bpt) {
419 PrintPropertyName(name); 419 PrintPropertyName(name);
420 PrintValue(bpt); 420 PrintValue(bpt);
421 } 421 }
422 422
423 423
424 void JSONStream::PrintProperty(const char* name, Metric* metric) { 424 void JSONStream::PrintProperty(const char* name, Metric* metric) {
425 PrintPropertyName(name); 425 PrintPropertyName(name);
426 PrintValue(metric); 426 PrintValue(metric);
427 } 427 }
428 428
(...skipping 159 matching lines...) Expand 10 before | Expand all | Expand 10 after
588 intptr_t len2 = OS::VSNPrint(p, len+1, format, args); 588 intptr_t len2 = OS::VSNPrint(p, len+1, format, args);
589 va_end(args); 589 va_end(args);
590 ASSERT(len == len2); 590 ASSERT(len == len2);
591 stream_->buffer_.AddChar('"'); 591 stream_->buffer_.AddChar('"');
592 stream_->AddEscapedUTF8String(p); 592 stream_->AddEscapedUTF8String(p);
593 stream_->buffer_.AddChar('"'); 593 stream_->buffer_.AddChar('"');
594 free(p); 594 free(p);
595 } 595 }
596 596
597 } // namespace dart 597 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/json_stream.h ('k') | runtime/vm/object_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698