Make Platform.executable return a fully qualified path the the executable

runtime/bin/platform_win.cc

Index: runtime/bin/platform_win.cc
diff --git a/runtime/bin/platform_win.cc b/runtime/bin/platform_win.cc
index 97d54cc8e7f55a561ba96da900ad2ca0a08476a9..afa924bab82e4cfa82eb7f5bfcd8cbc229281569 100644
--- a/runtime/bin/platform_win.cc
+++ b/runtime/bin/platform_win.cc
@@ -80,6 +80,26 @@ void Platform::FreeEnvironment(char** env, intptr_t count) {
   delete[] env;
 }
 
+
+char* Platform::ResolveExecutablePath() {
+  // GetModuleFileNameW cannot directly provide information on the
+  // required buffer size, so start out with a buffer large enough to
+  // hold any Windows path.
+  const int kTmpBufferSize = 32768;

[kustermann, 2015/05/20 10:19:56]

Isn't there a much shorter maximum path length?

[Lasse Reichstein Nielsen, 2015/05/20 10:48:43]

Not according to https://msdn.microsoft.com/en-us/library/aa365247(VS.85).aspx
You have to do extra work to use long paths, but they can work.

[Søren Gjesse, 2015/05/20 11:14:24]

According to
https://msdn.microsoft.com/en-us/library/windows/desktop/aa365247%28v=vs.85%2...
extended-length path (with the "\\?\" prefix) can be that long, and
GetModuleFileNameW will return in the format used to start the process. So if a
process was started using the "\\?\" prefix the path can be that long.

+  wchar_t* tmp_buffer = reinterpret_cast<wchar_t*>(malloc(kTmpBufferSize));
+  // Ensure no last error before calling GetModuleFileNameW.
+  SetLastError(ERROR_SUCCESS);
+  // Get the required length of the buffer.
+  int path_length = GetModuleFileNameW(NULL, tmp_buffer, kTmpBufferSize);
+  if (GetLastError() != ERROR_SUCCESS) {
+    free(tmp_buffer);
+    return NULL;
+  }
+  char* path = StringUtils::WideToUtf8(tmp_buffer);
+  free(tmp_buffer);
+  return path;
+}
+
 }  // namespace bin
 }  // namespace dart