Make Platform.executable return a fully qualified path the the executable

runtime/bin/platform_macos.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/globals.h"
 #if defined(TARGET_OS_MACOS)
 
+#include <mach-o/dyld.h>
+
 #include "bin/platform.h"
 
 #include <crt_externs.h>  // NOLINT
 #include <signal.h>  // NOLINT
 #include <string.h>  // NOLINT
 #include <unistd.h>  // NOLINT
 
 #include "bin/fdutils.h"
 
 
@@ skipping 50 matching lines @@
     result[current] = environ[current];
   }
   return result;
 }
 
 
 void Platform::FreeEnvironment(char** env, intptr_t count) {
   delete[] env;
 }
 
+
+char* Platform::ResolveExecutablePath() {
+  // Get the required length of the buffer.
+  uint32_t path_size = 0;
+  char* path = NULL;
+  if (_NSGetExecutablePath(path, &path_size) != -1) {

[Lasse Reichstein Nielsen, 2015/05/20 10:48:43]

Could "!= -1" be ">= 0".
(I just don't like unnamed constants other than 0 :)

[Søren Gjesse, 2015/05/20 11:14:24]

Changed to "== 0" then. The documentation explicitly says either -1 or 0.

+    return NULL;
+  }
+  // Allocate buffer and get executable path.
+  path = reinterpret_cast<char*>(malloc(path_size));
+  if (_NSGetExecutablePath(path, &path_size) != 0) {
+    free(path);
+    return NULL;
+  }
+  return path;
+}
+
 }  // namespace bin
 }  // namespace dart
 
 #endif  // defined(TARGET_OS_MACOS)