content/public/browser/browser_message_filter.cc - Issue 1145013004: Introduce bad_message.h for chrome and NaCl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/browser_message_filter.cc

Issue 1145013004: Introduce bad_message.h for chrome and NaCl. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Small fix to extensions/browser/bad_message.h Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/public/browser/browser_message_filter.cc

diff --git a/content/public/browser/browser_message_filter.cc b/content/public/browser/browser_message_filter.cc

index cb75ff1b86a6e933cd0271deb01a7467eeb833a0..e99e0446f4ed07944f29d1af0c306b67bd9b6be2 100644

--- a/content/public/browser/browser_message_filter.cc

+++ b/content/public/browser/browser_message_filter.cc

@@ -176,11 +176,12 @@ bool BrowserMessageFilter::CheckCanDispatchOnUI(const IPC::Message& message,

return true;

}

-void BrowserMessageFilter::BadMessageReceived() {

+void BrowserMessageFilter::ShutdownForBadMessage() {

base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();

if (command_line->HasSwitch(switches::kDisableKillAfterBadIPC))

return;

+ // TODO(nick): Should this work differently on Android?

BrowserChildProcessHostImpl::HistogramBadMessageTerminated(

PROCESS_TYPE_RENDERER);

peer_process_.Terminate(content::RESULT_CODE_KILLED_BAD_MESSAGE, false);