Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Unified Diff: components/nacl/browser/nacl_file_host.cc

Issue 1145013004: Introduce bad_message.h for chrome and NaCl. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Small fix to extensions/browser/bad_message.h Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/nacl/browser/nacl_file_host.cc
diff --git a/components/nacl/browser/nacl_file_host.cc b/components/nacl/browser/nacl_file_host.cc
index f3849108b172cc35629c4f1b0d1ff9eeb9c3092c..58c242fedae82adef35db071a3d3340240416abb 100644
--- a/components/nacl/browser/nacl_file_host.cc
+++ b/components/nacl/browser/nacl_file_host.cc
@@ -10,6 +10,7 @@
#include "base/files/file_util.h"
#include "base/strings/utf_string_conversions.h"
#include "base/threading/sequenced_worker_pool.h"
+#include "components/nacl/browser/bad_message.h"
#include "components/nacl/browser/nacl_browser.h"
#include "components/nacl/browser/nacl_browser_delegate.h"
#include "components/nacl/browser/nacl_host_message_filter.h"
@@ -248,7 +249,10 @@ void OpenNaClExecutable(
content::RenderViewHost* rvh = content::RenderViewHost::FromID(
nacl_host_message_filter->render_process_id(), render_view_id);
if (!rvh) {
- nacl_host_message_filter->BadMessageReceived(); // Kill the renderer.
+ nacl::bad_message::ReceivedBadMessage(
+ nacl_host_message_filter.get(),
+ nacl::bad_message::NACL_OPEN_EXECUTABLE_BAD_ROUTING_ID);
+ delete reply_msg;
James Cook 2015/05/22 18:13:10 We leaked this before? Good catch.
ncarter (slow) 2015/05/22 18:41:51 Acknowledged.
return;
}
content::SiteInstance* site_instance = rvh->GetSiteInstance();

Powered by Google App Engine
This is Rietveld 408576698