Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Side by Side Diff: chrome/browser/bad_message.h

Issue 1145013004: Introduce bad_message.h for chrome and NaCl. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comment change. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/bad_message.cc » ('j') | components/nacl.gyp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef EXTENSIONS_BROWSER_BAD_MESSAGE_H_ 5 #ifndef CHROME_BROWSER_BAD_MESSAGE_H_
6 #define EXTENSIONS_BROWSER_BAD_MESSAGE_H_ 6 #define CHROME_BROWSER_BAD_MESSAGE_H_
7 7
8 namespace content { 8 namespace content {
9 class BrowserMessageFilter;
9 class RenderProcessHost; 10 class RenderProcessHost;
10 } 11 }
11 12
12 namespace extensions { 13 namespace chrome {
Lei Zhang 2015/05/26 23:14:38 We've decided not to use namespace chrome, so let'
ncarter (slow) 2015/06/01 17:36:20 Done.
13 namespace bad_message { 14 namespace bad_message {
14 15
15 // The browser process often chooses to terminate a renderer if it receives 16 // The browser process often chooses to terminate a renderer if it receives
16 // a bad IPC message. The reasons are tracked for metrics. 17 // a bad IPC message. The reasons are tracked for metrics.
17 // 18 //
18 // See also content/browser/bad_message.h. 19 // See also content/browser/bad_message.h.
19 // 20 //
20 // NOTE: Do not remove or reorder elements in this list. Add new entries at the 21 // NOTE: Do not remove or reorder elements in this list. Add new entries at the
21 // end. Items may be renamed but do not change the values. We rely on the enum 22 // end. Items may be renamed but do not change the values. We rely on the enum
22 // values in histograms. Also update histograms.xml with any new values. 23 // values in histograms. Also update histograms.xml with any new values.
23 enum BadMessageReason { 24 enum BadMessageReason {
24 EOG_BAD_ORIGIN = 0, 25 WRLHH_LOGGING_STOPPED_BAD_STATE = 0,
25 EVG_BAD_ORIGIN = 1, 26
26 BH_BLOB_NOT_OWNED = 2,
27 EH_BAD_EVENT_ID = 3,
28 // Please add new elements here. The naming convention is abbreviated class 27 // Please add new elements here. The naming convention is abbreviated class
29 // name (e.g. ExtensionHost becomes EH) plus a unique description of the 28 // name (e.g. RenderFrameHost becomes RFH) plus a unique description of the
30 // reason. 29 // reason.
31 BAD_MESSAGE_MAX 30 BAD_MESSAGE_MAX
32 }; 31 };
33 32
34 // Called when the browser receives a bad IPC message from an extension process. 33 // Called when the browser receives a bad IPC message from a renderer process on
35 // Logs the event, records a histogram metric for the |reason|, and terminates 34 // the UI thread. Logs the event, records a histogram metric for the |reason|,
36 // the process for |host|. 35 // and terminates the process for |host|.
37 void ReceivedBadMessage(content::RenderProcessHost* host, 36 void ReceivedBadMessage(content::RenderProcessHost* host,
38 BadMessageReason reason); 37 BadMessageReason reason);
39 38
40 } // bad_message 39 // Called when a browser message filter receives a bad IPC message from a
41 } // namespace extensions 40 // renderer or other child process. Logs the event, records a histogram metric
41 // for the |reason|, and terminates the process for |filter|.
42 void ReceivedBadMessage(content::BrowserMessageFilter* filter,
43 BadMessageReason reason);
42 44
43 #endif // EXTENSIONS_BROWSER_BAD_MESSAGE_H_ 45 } // namespace bad_message
46 } // namespace chrome
47
48 #endif // CHROME_BROWSER_BAD_MESSAGE_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/bad_message.cc » ('j') | components/nacl.gyp » ('J')

Powered by Google App Engine
This is Rietveld 408576698