Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 1145013002: Re-land %TypedArray%.prototype.{map,filter,some} (Closed)

Created:
5 years, 7 months ago by dehrenberg
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Re-land %TypedArray%.prototype.{map,filter,some} Previously this patch was attempted with reduce and reduceRight included; however, some of those tests crashed in the trybots. This version has just map, fiter and some, together with their tests. R=arv@chromium.org BUG=v8:3578 LOG=Y Committed: https://crrev.com/f6af3a492df73332ec5eadf5dd39664ac6d871da Cr-Commit-Position: refs/heads/master@{#28529}

Patch Set 1 #

Total comments: 7

Patch Set 2 : fixes from poorly done rebase, and avoiding an extra copy in map/filter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+306 lines, -47 lines) Patch
M src/array.js View 1 10 chunks +48 lines, -29 lines 0 comments Download
M src/harmony-typedarray.js View 1 6 chunks +62 lines, -18 lines 0 comments Download
A test/mjsunit/harmony/typedarray-iteration.js View 1 chunk +196 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
dehrenberg
5 years, 7 months ago (2015-05-20 06:35:41 UTC) #2
dehrenberg
5 years, 7 months ago (2015-05-20 06:35:42 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145013002/1
5 years, 7 months ago (2015-05-20 06:36:04 UTC) #6
commit-bot: I haz the power
Dry run: No LGTM from a valid reviewer yet. Only full committers are accepted. Even ...
5 years, 7 months ago (2015-05-20 06:36:08 UTC) #8
adamk
https://codereview.chromium.org/1145013002/diff/1/src/harmony-typedarray.js File src/harmony-typedarray.js (right): https://codereview.chromium.org/1145013002/diff/1/src/harmony-typedarray.js#newcode33 src/harmony-typedarray.js:33: function ConstructTypedArray(constructor, array) { Where is this called? https://codereview.chromium.org/1145013002/diff/1/src/harmony-typedarray.js#newcode36 ...
5 years, 7 months ago (2015-05-20 18:50:07 UTC) #9
arv (Not doing code reviews)
https://codereview.chromium.org/1145013002/diff/1/src/harmony-typedarray.js File src/harmony-typedarray.js (right): https://codereview.chromium.org/1145013002/diff/1/src/harmony-typedarray.js#newcode33 src/harmony-typedarray.js:33: function ConstructTypedArray(constructor, array) { Also, this function is defined ...
5 years, 7 months ago (2015-05-20 19:22:31 UTC) #11
dehrenberg
https://codereview.chromium.org/1145013002/diff/1/src/harmony-typedarray.js File src/harmony-typedarray.js (right): https://codereview.chromium.org/1145013002/diff/1/src/harmony-typedarray.js#newcode33 src/harmony-typedarray.js:33: function ConstructTypedArray(constructor, array) { On 2015/05/20 19:22:31, arv wrote: ...
5 years, 7 months ago (2015-05-20 23:39:01 UTC) #12
adamk
lgtm
5 years, 7 months ago (2015-05-21 00:03:19 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145013002/20001
5 years, 7 months ago (2015-05-21 00:07:41 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-21 01:38:26 UTC) #16
commit-bot: I haz the power
5 years, 7 months ago (2015-05-21 01:38:42 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f6af3a492df73332ec5eadf5dd39664ac6d871da
Cr-Commit-Position: refs/heads/master@{#28529}

Powered by Google App Engine
This is Rietveld 408576698