Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 1145003002: [Sync] Finish transition to new AndroidSyncSettings interface. (Closed)

Created:
5 years, 7 months ago by maxbogue
Modified:
5 years, 7 months ago
Reviewers:
nyquist
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, maniscalco+watch_chromium.org, maniscalco
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Finish transition to new AndroidSyncSettings interface. This is CL 3/3 in a series; please see http://crrev.com/1138013008 for more information. Storing references to AndroidSyncSettings is no longer allowed BUG=480604 Committed: https://crrev.com/0ee0b47930931ca47aa5100a5927f323ef4589b8 Cr-Commit-Position: refs/heads/master@{#330755}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -61 lines) Patch
M sync/android/java/src/org/chromium/sync/AndroidSyncSettings.java View 1 chunk +1 line, -61 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
maxbogue
Tommy, please review this last change. CC: Nick as an FYI.
5 years, 7 months ago (2015-05-20 04:50:50 UTC) #2
nyquist
lgtm
5 years, 7 months ago (2015-05-20 04:52:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145003002/1
5 years, 7 months ago (2015-05-20 16:55:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-20 16:59:32 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 17:01:21 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0ee0b47930931ca47aa5100a5927f323ef4589b8
Cr-Commit-Position: refs/heads/master@{#330755}

Powered by Google App Engine
This is Rietveld 408576698