cc/layers/layer_impl.cc - Issue 1144993004: cc: Make impl-thread property trees handle fixed-position layers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/layers/layer_impl.cc

Issue 1144993004: cc: Make impl-thread property trees handle fixed-position layers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@EnablePropertyTreeVerificationOnImpl

Patch Set: Add DCHECK Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/layers/layer_impl.cc

diff --git a/cc/layers/layer_impl.cc b/cc/layers/layer_impl.cc

index 65a7a507e6e22c824a9f9487f949742db3ce2619..b657b32dea0b8120e2feba74345d9c27797ba30f 100644

--- a/cc/layers/layer_impl.cc

+++ b/cc/layers/layer_impl.cc

@@ -1216,6 +1216,7 @@ gfx::Vector2dF LayerImpl::ScrollDelta() const {

void LayerImpl::SetScrollDelta(const gfx::Vector2dF& delta) {

DCHECK(IsActive());

+ DCHECK(scrollable() || delta.IsZero());

SetCurrentScrollOffset(scroll_offset_->ActiveBase() +

gfx::ScrollOffset(delta));

}

« no previous file with comments | « no previous file | cc/layers/layer_position_constraint_unittest.cc » ('j') | no next file with comments »