Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1144993002: [Sync] Remove periodic sync for Chrome for Android, take 2. (Closed)

Created:
5 years, 7 months ago by maxbogue
Modified:
5 years, 7 months ago
Reviewers:
nyquist
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Remove periodic sync for Chrome for Android, take 2. updateAccount() is always called on startup with the signed in account, so the removePeriodicSync() call will be hit even for already signed in users when the app restarts. This change was previously submitted as http://crrev.com/1148613002 but got reverted due to a bad merge caused by http://crrev.com/1138013008. BUG=480688 Committed: https://crrev.com/d0b9cf4b34450dc615f2f574d0af0c7010f33636 Cr-Commit-Position: refs/heads/master@{#330703}

Patch Set 1 #

Messages

Total messages: 7 (2 generated)
maxbogue
Hey Tommy, please take a look at this corrected CL. The only change is the ...
5 years, 7 months ago (2015-05-20 04:20:21 UTC) #2
nyquist
lgtm
5 years, 7 months ago (2015-05-20 04:57:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144993002/1
5 years, 7 months ago (2015-05-20 04:58:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-20 05:25:40 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 05:26:26 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d0b9cf4b34450dc615f2f574d0af0c7010f33636
Cr-Commit-Position: refs/heads/master@{#330703}

Powered by Google App Engine
This is Rietveld 408576698