chrome/browser/ui/webui/print_preview/print_preview_ui.cc - Issue 1144983002: Introduce concept of provisional destinations to print preview

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/print_preview/print_preview_ui.cc

Issue 1144983002: Introduce concept of provisional destinations to print preview (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/print_preview/search/destination_search.js ('K') | « chrome/browser/resources/print_preview/search/provisional_destination_resolver.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/print_preview/print_preview_ui.cc

diff --git a/chrome/browser/ui/webui/print_preview/print_preview_ui.cc b/chrome/browser/ui/webui/print_preview/print_preview_ui.cc

index 6d6ffae07cb9e97e70167b35b724c76c24eb7b3b..43df8378aec1f7b3f78ec2215f4e396fb7901f26 100644

--- a/chrome/browser/ui/webui/print_preview/print_preview_ui.cc

+++ b/chrome/browser/ui/webui/print_preview/print_preview_ui.cc

@@ -210,6 +210,16 @@ content::WebUIDataSource* CreatePrintPreviewUISource() {

IDS_PRINT_PREVIEW_PAGE_LABEL_SINGULAR);

source->AddLocalizedString("printPreviewPageLabelPlural",

IDS_PRINT_PREVIEW_PAGE_LABEL_PLURAL);

+ source->AddLocalizedString("selectButton",

+ IDS_PRINT_PREVIEW_BUTTON_SELECT);

+ source->AddLocalizedString("goBackButton",

+ IDS_PRINT_PREVIEW_BUTTON_GO_BACK);

+ source->AddLocalizedString(

+ "resolveExtensionUSBPermissionMessage",

+ IDS_PRINT_PREVIEW_RESOLVE_EXTENSION_USB_PERMISSION_MESSAGE);

+ source->AddLocalizedString(

+ "resolveExtensionUSBErrorMessage",

+ IDS_PRINT_PREVIEW_RESOLVE_EXTENSION_USB_ERROR_MESSAGE);

const base::string16 shortcut_text(base::UTF8ToUTF16(kBasicPrintShortcut));

#if !defined(OS_CHROMEOS)

source->AddString(