chrome/browser/resources/print_preview/print_preview_focus_manager.js - Issue 1144983002: Introduce concept of provisional destinations to print preview

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/print_preview/print_preview_focus_manager.js

Issue 1144983002: Introduce concept of provisional destinations to print preview (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/print_preview/print_preview.js ('k') | chrome/browser/resources/print_preview/search/destination_search.css » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/print_preview/print_preview_focus_manager.js

diff --git a/chrome/browser/resources/print_preview/print_preview_focus_manager.js b/chrome/browser/resources/print_preview/print_preview_focus_manager.js

index be4c22d06d01465d20fd834892e476bf2577a109..b5d74efdc21becda696c0e1517ffdbe2b0efe5ad 100644

--- a/chrome/browser/resources/print_preview/print_preview_focus_manager.js

+++ b/chrome/browser/resources/print_preview/print_preview_focus_manager.js

@@ -21,8 +21,11 @@ cr.define('print_preview', function() {

/** @override */

getFocusParent: function() {

- return document.querySelector('.overlay:not([hidden])') ||

- document.body;

+ var el = document.body;

tbarzic 2015/05/27 17:10:11 needed to handle showing an overlay (USB permissio

+ var newEl = null;

+ while (newEl = el.querySelector('.overlay:not([hidden])'))

+ el = newEl;

+ return el;

}

};