chrome/browser/resources/print_preview/data/local_parsers.js - Issue 1144983002: Introduce concept of provisional destinations to print preview

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/print_preview/data/local_parsers.js

Issue 1144983002: Introduce concept of provisional destinations to print preview (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/print_preview/data/destination_store.js ('k') | chrome/browser/resources/print_preview/native_layer.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/print_preview/data/local_parsers.js

diff --git a/chrome/browser/resources/print_preview/data/local_parsers.js b/chrome/browser/resources/print_preview/data/local_parsers.js

index d367134e04e15823551afdf9f3f68ece1627c330..f6b4c734958bcf4dc26f824270ccf1bbd039cb46 100644

--- a/chrome/browser/resources/print_preview/data/local_parsers.js

+++ b/chrome/browser/resources/print_preview/data/local_parsers.js

@@ -75,6 +75,11 @@ cr.define('print_preview', function() {

* @return {!print_preview.Destination} Parsed destination.

ExtensionDestinationParser.parse = function(destinationInfo) {

+ var provisionalType =

+ destinationInfo.provisional ?

+ print_preview.Destination.ProvisionalType.NEEDS_USB_PERMISSION :

+ print_preview.Destination.ProvisionalType.NONE;

return new print_preview.Destination(

destinationInfo.id,

print_preview.Destination.Type.LOCAL,

@@ -84,7 +89,8 @@ cr.define('print_preview', function() {

print_preview.Destination.ConnectionStatus.ONLINE,

{description: destinationInfo.description || '',

extensionId: destinationInfo.extensionId,

- extensionName: destinationInfo.extensionName || ''});

+ extensionName: destinationInfo.extensionName || '',

+ provisionalType: provisionalType});

};

// Export