Issue 1144973005: cc: TilingSetRasterQueue clean-ups and optimizations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1144973005: cc: TilingSetRasterQueue clean-ups and optimizations. (Closed)

Created:
5 years, 7 months ago by vmpstr

Modified:
5 years, 7 months ago

Reviewers:
USE eero AT chromium.org, enne (OOO)

CC:
cc-bugs_chromium.org, chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

cc: TilingSetRasterQueue clean-ups and optimizations. This patch removes some redundant code (fixing a bunch of TODOs). Also ensures that we only call pending_visible_rect once per iterator (since the function involves a virtual call). R=enne BUG=488636 Committed: https://crrev.com/b38ea4aec6a0c9cc8460b8420b292e5cc479a8a1 Cr-Commit-Position: refs/heads/master@{#330787}

Patch Set 1 #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -47 lines)			Patch
	M	cc/tiles/tiling_set_raster_queue_all.h	View		4 chunks	+1 line, -3 lines	0 comments	Download
	M	cc/tiles/tiling_set_raster_queue_all.cc	View		9 chunks	+8 lines, -44 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144973005/1

5 years, 7 months ago (2015-05-20 18:22:39 UTC) #5

commit-bot: I haz the power

5 years, 7 months ago (2015-05-20 19:52:31 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/b38ea4aec6a0c9cc8460b8420b292e5cc479a8a1
Cr-Commit-Position: refs/heads/master@{#330787}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages