Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1144973003: Sort build files for consistent link order. (Closed)

Created:
5 years, 7 months ago by bungeman-skia
Modified:
5 years, 7 months ago
Reviewers:
hal.canary, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Sort build files for consistent link order. Prior to the introduction of find.py, GMs were liked in the order they were listed in the gypi file, which was generally alphabetically. This made it fairly easy to predict where slides would show up in SampleApp and the order was consistent. This simply sorts the list of files in find.py to restore the expectation that files should be listed in the build in alphabetical order. Committed: https://skia.googlesource.com/skia/+/22483d9ca6e393635ffdf371c35026f0e8ec429c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M gyp/find.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
bungeman-skia
I used .sort() instead of sorted() because that's how I roll.
5 years, 7 months ago (2015-05-20 16:19:18 UTC) #2
mtklein
lgtm
5 years, 7 months ago (2015-05-20 16:19:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144973003/1
5 years, 7 months ago (2015-05-20 16:20:18 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/22483d9ca6e393635ffdf371c35026f0e8ec429c
5 years, 7 months ago (2015-05-20 16:26:52 UTC) #6
Stephen White
5 years, 7 months ago (2015-05-20 16:48:30 UTC) #7
Message was sent while issue was closed.
Thank you! This was driving me bananas.

Powered by Google App Engine
This is Rietveld 408576698