Source/devtools/front_end/timeline/TimelineFlameChart.js - Issue 1144963002: Timeline: visually distinguish idle frames

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/timeline/TimelineFlameChart.js

Issue 1144963002: Timeline: visually distinguish idle frames (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: review comments Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/devtools/front_end/timeline/TimelineFlameChart.js

diff --git a/Source/devtools/front_end/timeline/TimelineFlameChart.js b/Source/devtools/front_end/timeline/TimelineFlameChart.js

index efb8165fab752d650898908b13c9ae9f6480d2ef..de2e390c6673a0d90b0b987872b92d9d4f7eba60 100644

--- a/Source/devtools/front_end/timeline/TimelineFlameChart.js

+++ b/Source/devtools/front_end/timeline/TimelineFlameChart.js

@@ -580,7 +580,7 @@ WebInspector.TimelineFlameChartDataProvider.prototype = {

barY += vPadding;

barHeight -= 2 * vPadding + 1;

- context.fillStyle = "#ccc";

+ context.fillStyle = frame.idle ? "#eee" : "#ccc";

context.fillRect(barX, barY, barWidth, barHeight);

// Draw frame perforation.