Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: LayoutTests/inspector/tracing/frame-model.html

Issue 1144963002: Timeline: visually distinguish idle frames (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: review comments Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/inspector/tracing/frame-model.html
diff --git a/LayoutTests/inspector/tracing/frame-model.html b/LayoutTests/inspector/tracing/frame-model.html
index 33cc8ce63e0ab6aaa73733e1679d12501097fa88..89c7a280db45eb22067b9d5b1073f25d22a1b593 100644
--- a/LayoutTests/inspector/tracing/frame-model.html
+++ b/LayoutTests/inspector/tracing/frame-model.html
@@ -240,7 +240,28 @@ function test()
{"name": "BeginFrame", "ts": 1048000, args: { "layerTreeId": 17 }, "ph": "I", "tid": implThread, "pid": 100, "cat":"disabled-by-default-devtools.timeline" },
{"name": "Program", "ts": 1049000, args: {}, "dur": 999, "ph": "X", "tid": mainThread, "pid": 100, "cat":"disabled-by-default-devtools.timeline" },
- ]
+ ],
+ "Idle frames": [
+ {"name": "BeginFrame", "ts": 1000000, args: { "layerTreeId": 17 }, "ph": "I", "tid": implThread, "pid": 100, "cat":"disabled-by-default-devtools.timeline" },
+ {"name": "ActivateLayerTree", "ts": 1014000, args: { "layerTreeId": 17 }, "ph": "I", "tid": implThread, "pid": 100, "cat":"disabled-by-default-devtools.timeline" },
+ {"name": "DrawFrame", "ts": 1014001, args: { "layerTreeId": 17 }, "ph": "I", "tid": implThread, "pid": 100, "cat":"disabled-by-default-devtools.timeline" },
+ {"name": "NeedsBeginFrameChanged", "ts": 1015000, args: { "layerTreeId": 17, "data": { "needsBeginFrame": false } }, "ph": "I", "tid": implThread, "pid": 100, "cat":"disabled-by-default-devtools.timeline" },
+ {"name": "NeedsBeginFrameChanged", "ts": 1215000, args: { "layerTreeId": 17, "data": { "needsBeginFrame": true } }, "ph": "I", "tid": implThread, "pid": 100, "cat":"disabled-by-default-devtools.timeline" },
+ {"name": "BeginFrame", "ts": 1231000, args: { "layerTreeId": 17 }, "ph": "I", "tid": implThread, "pid": 100, "cat":"disabled-by-default-devtools.timeline" },
+ {"name": "BeginFrame", "ts": 1247000, args: { "layerTreeId": 17 }, "ph": "I", "tid": implThread, "pid": 100, "cat":"disabled-by-default-devtools.timeline" },
+ {"name": "BeginFrame", "ts": 1263000, args: { "layerTreeId": 17 }, "ph": "I", "tid": implThread, "pid": 100, "cat":"disabled-by-default-devtools.timeline" },
+ {"name": "RequestMainThreadFrame", "ts": 1263001, args: { "layerTreeId": 17 }, "ph": "I", "tid": implThread, "pid": 100, "cat":"disabled-by-default-devtools.timeline" },
+
+ {"name": "Program", "ts": 1264000, args: {}, "dur": 24000, "ph": "X", "tid": mainThread, "pid": 100, "cat":"disabled-by-default-devtools.timeline" },
+ {"name": "BeginMainThreadFrame", "ts": 1264001, args: {}, "ph": "I", "tid": mainThread, "pid": 100, "cat":"disabled-by-default-devtools.timeline" },
+ {"name": "FunctionCall", "ts": 1264002, args: {}, "dur": 23000, "ph": "X", "tid": mainThread, "pid": 100, "cat":"disabled-by-default-devtools.timeline" },
+ {"name": "CompositeLayers", "ts": 1287003, args: { "layerTreeId": 17 }, "dur": 500, "ph": "X", "tid": mainThread, "pid": 100, "cat":"disabled-by-default-devtools.timeline" },
+ {"name": "ActivateLayerTree", "ts": 1270000, args: { "layerTreeId": 17 }, "ph": "I", "tid": implThread, "pid": 100, "cat":"disabled-by-default-devtools.timeline" },
+ {"name": "DrawFrame", "ts": 1270001, args: { "layerTreeId": 17 }, "ph": "I", "tid": implThread, "pid": 100, "cat":"disabled-by-default-devtools.timeline" },
+ {"name": "ActivateLayerTree", "ts": 1296000, args: { "layerTreeId": 17 }, "ph": "I", "tid": implThread, "pid": 100, "cat":"disabled-by-default-devtools.timeline" },
+ {"name": "DrawFrame", "ts": 1296001, args: { "layerTreeId": 17 }, "ph": "I", "tid": implThread, "pid": 100, "cat":"disabled-by-default-devtools.timeline" },
+ {"name": "DrawFrame", "ts": 1312000, args: { "layerTreeId": 17 }, "ph": "I", "tid": implThread, "pid": 100, "cat":"disabled-by-default-devtools.timeline" },
+ ],
};
var frameModel = new WebInspector.TracingTimelineFrameModel();
« no previous file with comments | « LayoutTests/http/tests/inspector/timeline-test.js ('k') | LayoutTests/inspector/tracing/frame-model-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698