Timeline: visually distinguish idle frames

Timeline: visually distinguish idle frames

Long frames produced by idle periods between two DrawFrames are confusing,
so detect when frames are absent becase CC thinks page is idle and render
these differently (skip outline in overview, draw frame bar in pale for flame chart).

BUG=462516
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196596

[caseq, 2015-05-20 01:16:37]

caseq@chromium.org changed reviewers:
+ alph@chromium.org, pfeldman@chromium.org, yurys@chromium.org

[alph, 2015-05-20 01:32:55]

I'm not sure about these wavy lines. They are confusing. Perhaps if we just drop
them and show an empty space it will also work.

[caseq, 2015-05-20 01:38:23]

On 2015/05/20 01:32:55, alph wrote:
> I'm not sure about these wavy lines. They are confusing. Perhaps if we just
drop
> them and show an empty space it will also work.

So we would have ranges of time in the bottom view (e.g. flame chart) that don't
map to anything in the frame overview, right?
Also, some poorly-written animation (e.g. using setTimeout() would be visually
indistinguishable from regular frames.

[caseq, 2015-05-26 16:56:43]

ptal -- as discussed, now just skip drawing outline for idle frames.

[caseq, 2015-06-01 16:53:15]

ping

[caseq, 2015-06-03 14:13:07]

ping

[alph, 2015-06-03 14:14:47]

Can't find an updated screenshot. Is the last one from the bug is still valid?

[caseq, 2015-06-03 17:17:13]

On 2015/06/03 14:14:47, alph wrote:
> Can't find an updated screenshot. Is the last one from the bug is still valid?

Ah, sorry, I did not update the screenshot -- thought it's not required given
how everyone involved into the offline discussion seemed to imagine that to be
the way to go. Added it now.

[alph, 2015-06-05 16:55:39]

lgtm

https://codereview.chromium.org/1144963002/diff/60001/Source/devtools/front_e...
File Source/devtools/front_end/timeline/TimelineFrameModel.js (right):

https://codereview.chromium.org/1144963002/diff/60001/Source/devtools/front_e...
Source/devtools/front_end/timeline/TimelineFrameModel.js:212:
this._lastBeginFrame = null;
Don't you need to reset _lastNeedsBeginFrame as well?

https://codereview.chromium.org/1144963002/diff/60001/Source/devtools/front_e...
File Source/devtools/front_end/timeline/TimelineFrameOverview.js (right):

https://codereview.chromium.org/1144963002/diff/60001/Source/devtools/front_e...
Source/devtools/front_end/timeline/TimelineFrameOverview.js:205: var
longestDuration = -Infinity;
nit: the initial value doesn't really matter.

[caseq, 2015-06-05 17:26:24]

The CQ bit was checked by caseq@chromium.org

[caseq, 2015-06-05 17:26:24]

The patchset sent to the CQ was uploaded after l-g-t-m from alph@chromium.org
Link to the patchset: https://codereview.chromium.org/1144963002/#ps80001
(title: "review comments")

[commit-bot: I haz the power, 2015-06-05 17:26:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1144963002/80001

[commit-bot: I haz the power, 2015-06-05 18:37:22]

Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196596