Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(3)

Issue 1144953007: Remove tabStop feature (Closed)

Created:
4 years, 10 months ago by kochi
Modified:
4 years, 10 months ago
Reviewers:
tkent, esprehn, hayato
CC:
blink-reviews, blink-reviews-html_chromium.org, arv+blink, vivekg, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, vivekg_samsung, Inactive, rwlbuis
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Remove tabStop feature This feature will retire in favor of new 'delegatesFocus' property on shadow roots. This CL removes all the code related to 'tabStop' feature as well as its RuntimeEnabledFeatures, UseCounters (TabStopProperty, TabStopAttribute), and its layout tests. BUG=380445, 496005 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196726

Patch Set 1 #

Patch Set 2 : Remove layout tests. #

Patch Set 3 : Remove tabStop for real #

Patch Set 4 : rebase #

Patch Set 5 : remove usecounter definitions #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1824 lines) Patch
D LayoutTests/fast/dom/shadow/css-focus-pseudo-match-shadow-host.html View 1 1 chunk +0 lines, -356 lines 0 comments Download
D LayoutTests/fast/dom/shadow/css-focus-pseudo-match-shadow-host-expected.txt View 1 1 chunk +0 lines, -81 lines 0 comments Download
D LayoutTests/fast/dom/shadow/focus-method-with-tabstop.html View 1 1 chunk +0 lines, -84 lines 0 comments Download
D LayoutTests/fast/dom/shadow/focus-method-with-tabstop-expected.txt View 1 1 chunk +0 lines, -27 lines 0 comments Download
D LayoutTests/fast/dom/shadow/focus-navigation-tabstop-crash.html View 1 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/fast/dom/shadow/focus-navigation-tabstop-crash-expected.txt View 1 1 chunk +0 lines, -8 lines 0 comments Download
D LayoutTests/fast/dom/shadow/focus-navigation-with-tabstop.html View 1 1 chunk +0 lines, -163 lines 0 comments Download
D LayoutTests/fast/dom/shadow/focus-navigation-with-tabstop-expected.txt View 1 1 chunk +0 lines, -96 lines 0 comments Download
D LayoutTests/fast/dom/shadow/focus-shadowhost-display-none.html View 1 1 chunk +0 lines, -62 lines 0 comments Download
D LayoutTests/fast/dom/shadow/focus-shadowhost-display-none-expected.txt View 1 1 chunk +0 lines, -23 lines 0 comments Download
D LayoutTests/fast/dom/shadow/focus-slide-on-shadow-host.html View 1 1 chunk +0 lines, -108 lines 0 comments Download
D LayoutTests/fast/dom/shadow/focus-slide-on-shadow-host-expected.txt View 1 1 chunk +0 lines, -30 lines 0 comments Download
D LayoutTests/fast/dom/shadow/focusable-elements-with-tabstop.html View 1 1 chunk +0 lines, -196 lines 0 comments Download
D LayoutTests/fast/dom/shadow/focusable-elements-with-tabstop-expected.txt View 1 1 chunk +0 lines, -83 lines 0 comments Download
D LayoutTests/fast/dom/shadow/tabstop-focus-highlight-sibling.html View 1 1 chunk +0 lines, -135 lines 0 comments Download
D LayoutTests/fast/dom/shadow/tabstop-focus-highlight-sibling-expected.txt View 1 1 chunk +0 lines, -41 lines 0 comments Download
D LayoutTests/fast/dom/shadow/tabstop-property.html View 1 1 chunk +0 lines, -120 lines 0 comments Download
D LayoutTests/fast/dom/shadow/tabstop-property-expected.txt View 1 1 chunk +0 lines, -48 lines 0 comments Download
M LayoutTests/platform/android/webexposed/global-interface-listing-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/webexposed/element-instance-property-listing-expected.txt View 1 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 3 4 5 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/dom/ContainerNode.cpp View 1 2 1 chunk +0 lines, -14 lines 0 comments Download
M Source/core/dom/Element.h View 1 2 2 chunks +1 line, -5 lines 0 comments Download
M Source/core/dom/Element.cpp View 1 2 3 4 5 4 chunks +1 line, -63 lines 0 comments Download
M Source/core/dom/Element.idl View 1 2 3 4 5 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/dom/ElementRareData.h View 3 chunks +0 lines, -6 lines 0 comments Download
M Source/core/dom/Node.h View 1 2 3 4 5 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/HTMLAttributeNames.in View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/input/EventHandler.h View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/input/EventHandler.cpp View 1 2 2 chunks +0 lines, -24 lines 0 comments Download
M Source/core/page/FocusController.cpp View 1 2 4 chunks +2 lines, -14 lines 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 20 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144953007/60001
4 years, 10 months ago (2015-06-08 05:52:57 UTC) #3
kochi
PTAL
4 years, 10 months ago (2015-06-08 06:03:30 UTC) #4
hayato
lgtm
4 years, 10 months ago (2015-06-08 06:51:43 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2015-06-08 07:24:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144953007/60001
4 years, 10 months ago (2015-06-08 07:25:58 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/34792)
4 years, 10 months ago (2015-06-08 07:32:58 UTC) #11
kochi
tkent-san, Could you review for RuntimeEnabledFeatures.in?
4 years, 10 months ago (2015-06-09 01:01:06 UTC) #13
tkent
> (TabStopProperty, TabStopAttribute - definitions will stay), Why do you keep them?
4 years, 10 months ago (2015-06-09 01:05:48 UTC) #14
kochi
On 2015/06/09 01:05:48, tkent wrote: > > (TabStopProperty, TabStopAttribute - definitions will stay), > > ...
4 years, 10 months ago (2015-06-09 01:18:56 UTC) #15
tkent
lgtm
4 years, 10 months ago (2015-06-09 01:20:53 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144953007/100001
4 years, 10 months ago (2015-06-09 01:21:40 UTC) #19
commit-bot: I haz the power
4 years, 10 months ago (2015-06-09 03:00:45 UTC) #20
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196726

Powered by Google App Engine
This is Rietveld 408576698