Source/platform/heap/ThreadState.cpp - Issue 1144933004: Revert of Various ASan exemptions to allow Oilpan pre-sweep poisoning of unmarkeds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/heap/ThreadState.cpp

Issue 1144933004: Revert of Various ASan exemptions to allow Oilpan pre-sweep poisoning of unmarkeds. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/platform/heap/ThreadState.cpp

diff --git a/Source/platform/heap/ThreadState.cpp b/Source/platform/heap/ThreadState.cpp

index 1b20f981cf9b388edb60b2582881add495171f4b..699866a4516830374b32646ac8351c86a8c97e33 100644

--- a/Source/platform/heap/ThreadState.cpp

+++ b/Source/platform/heap/ThreadState.cpp

@@ -895,8 +895,10 @@

}

#if defined(ADDRESS_SANITIZER)

-// TODO(Oilpan): enable the poisoning always.

-#if ENABLE(OILPAN)

+// TODO(haraken): Currently we cannot enable the poisoning because we have

+// real bugs where destructors touch other on-heap objects. Remove all the bugs

+// and enable the poisoning.

+#if 0

for (int i = 0; i < NumberOfHeaps; i++)

m_heaps[i]->poisonUnmarkedObjects();

#endif

« no previous file with comments | « Source/platform/heap/Handle.h ('k') | Source/wtf/LinkedHashSet.h » ('j') | no next file with comments »