src/effects/SkBitmapSource.cpp - Issue 114493005: Fixing valgrind error

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkBitmapSource.cpp

Issue 114493005: Fixing valgrind error (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkBitmapSource.cpp

diff --git a/src/effects/SkBitmapSource.cpp b/src/effects/SkBitmapSource.cpp

index ef5ea8692568b3c818d977aa885b5517aa53aea3..b5ee1dd83464bc9087a33d340a0928bf568db6bf 100644

--- a/src/effects/SkBitmapSource.cpp

+++ b/src/effects/SkBitmapSource.cpp

@@ -31,7 +31,7 @@ SkBitmapSource::SkBitmapSource(SkFlattenableReadBuffer& buffer)

fBitmap.unflatten(buffer);

buffer.readRect(&fSrcRect);

buffer.readRect(&fDstRect);

- buffer.validate(SkIsValidRect(fSrcRect) && SkIsValidRect(fDstRect));

+ buffer.validate(buffer.isValid() && SkIsValidRect(fSrcRect) && SkIsValidRect(fDstRect));

}

void SkBitmapSource::flatten(SkFlattenableWriteBuffer& buffer) const {

« no previous file with comments | « no previous file | no next file » | no next file with comments »