Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 1144913002: Drop the document.charset part of fast/encoding/external-script-charset.xhtml (Closed)

Created:
5 years, 7 months ago by philipj_slow
Modified:
5 years, 7 months ago
Reviewers:
pdr.
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Drop the document.charset part of fast/encoding/external-script-charset.xhtml Simplify to only test the inheritance, but use the koi8-r for the XHTML document to ensure that it's not just the default encoding being used to decode the script. The bots cannot apply this patch because of the encoding of LayoutTests/fast/encoding/external-script-charset-koi-8.js. BUG=438392 R=pdr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195595

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -14 lines) Patch
D LayoutTests/fast/encoding/external-script-charset.js View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/encoding/external-script-charset.xhtml View 1 chunk +3 lines, -5 lines 0 comments Download
M LayoutTests/fast/encoding/external-script-charset-expected.txt View 1 chunk +1 line, -4 lines 0 comments Download
M LayoutTests/fast/encoding/external-script-charset-koi-8.js View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
philipj_slow
PTAL. I'm doing this separately before the bigger CL to make document.charset readonly, as I ...
5 years, 7 months ago (2015-05-19 22:53:22 UTC) #2
pdr.
LGTM git cl dcommit away
5 years, 7 months ago (2015-05-19 23:28:33 UTC) #3
philipj_slow
5 years, 7 months ago (2015-05-20 07:43:38 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 195595 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698