Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 1144883003: handle large conic strokes better (Closed)

Created:
5 years, 7 months ago by caryclark
Modified:
5 years, 7 months ago
Reviewers:
f(malita), reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

handle large conic strokes better A stroked conic computes the outset quad's control point by computing the intersection of the quad's endpoints. If the the denominator used to compute the scale factor for the control point is small, check to see if the numerator is also small so that the division stays bounded. Also clean up error returns and internal function calls to simplify the code. Additionally, remove comic max curvature (unimplemented) and call extrema functions instead to handle cases where the conic is degenerate or is a line. R=reed@google.com, fmalita@chromium.org BUG=skia:3843 Committed: https://skia.googlesource.com/skia/+/612f70d5fa2d4bf7a393c791966bbce933407017

Patch Set 1 #

Patch Set 2 : add assert for tricky denom check #

Patch Set 3 : fix degenerate line; remove conic max curvature #

Patch Set 4 : fix dm-driven very large curve case #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -54 lines) Patch
M gm/strokes.cpp View 1 chunk +30 lines, -0 lines 0 comments Download
M samplecode/SampleQuadStroker.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkGeometry.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkGeometry.cpp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/core/SkStroke.cpp View 1 2 3 10 chunks +65 lines, -48 lines 0 comments Download
M tools/pathops_sorter.htm View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144883003/20001
5 years, 7 months ago (2015-05-19 15:29:27 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 7 months ago (2015-05-19 15:29:28 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/964)
5 years, 7 months ago (2015-05-19 15:33:47 UTC) #5
reed1
lgtm
5 years, 7 months ago (2015-05-19 16:58:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144883003/40001
5 years, 7 months ago (2015-05-19 17:25:42 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/967)
5 years, 7 months ago (2015-05-19 17:41:32 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144883003/10004
5 years, 7 months ago (2015-05-19 17:59:14 UTC) #14
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 18:05:42 UTC) #15
Message was sent while issue was closed.
Committed patchset #4 (id:10004) as
https://skia.googlesource.com/skia/+/612f70d5fa2d4bf7a393c791966bbce933407017

Powered by Google App Engine
This is Rietveld 408576698