Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 1144883002: Start adding support for elements to the LookupIterator (Closed)

Created:
5 years, 7 months ago by Toon Verwaest
Modified:
5 years, 7 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Start adding support for elements to the LookupIterator BUG=v8:4137 LOG=n Committed: https://crrev.com/16484824b65b6fc4e57c45dd4e055213021fb705 Cr-Commit-Position: refs/heads/master@{#28546}

Patch Set 1 #

Patch Set 2 : Deconfuse exotic integer handling #

Total comments: 1

Patch Set 3 : Addressed comments #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -49 lines) Patch
M src/elements.h View 1 2 3 5 2 chunks +10 lines, -3 lines 0 comments Download
M src/elements.cc View 1 2 3 5 12 chunks +76 lines, -31 lines 0 comments Download
M src/lookup.h View 1 2 6 chunks +53 lines, -2 lines 0 comments Download
M src/lookup.cc View 1 2 4 chunks +10 lines, -4 lines 0 comments Download
M src/lookup-inl.h View 1 2 3 4 3 chunks +18 lines, -9 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
Toon Verwaest
PTAL
5 years, 7 months ago (2015-05-19 15:05:48 UTC) #2
Jakob Kummerow
LGTM with a nit. https://codereview.chromium.org/1144883002/diff/10006/src/elements.cc File src/elements.cc (right): https://codereview.chromium.org/1144883002/diff/10006/src/elements.cc#newcode1531 src/elements.cc:1531: static uint32_t GetIndexForKeyImpl(FixedArrayBase* store, uint32_t ...
5 years, 7 months ago (2015-05-19 17:01:15 UTC) #3
Toon Verwaest
Addressed comments
5 years, 7 months ago (2015-05-19 17:14:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144883002/50001
5 years, 7 months ago (2015-05-20 21:01:42 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/builds/2715)
5 years, 7 months ago (2015-05-20 21:10:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144883002/70001
5 years, 7 months ago (2015-05-21 11:49:45 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/593) v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED, ...
5 years, 7 months ago (2015-05-21 11:50:58 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144883002/90001
5 years, 7 months ago (2015-05-21 11:54:48 UTC) #17
commit-bot: I haz the power
Committed patchset #6 (id:90001)
5 years, 7 months ago (2015-05-21 12:19:46 UTC) #18
commit-bot: I haz the power
5 years, 7 months ago (2015-05-21 12:20:04 UTC) #19
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/16484824b65b6fc4e57c45dd4e055213021fb705
Cr-Commit-Position: refs/heads/master@{#28546}

Powered by Google App Engine
This is Rietveld 408576698