Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1144873002: Add a callback for cancelling the context menu. (Closed)

Created:
5 years, 7 months ago by lliabraa
Modified:
5 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a callback for cancelling the context menu. The callback updates the |visible| property to NO so clients can correctly determine if the context menu has been dismissed. BUG=489121 Committed: https://crrev.com/1f113f3df1edef7c130691e5a36b65b95ff95eff Cr-Commit-Position: refs/heads/master@{#330562}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M ui/base/ios/cru_context_menu_controller.mm View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
lliabraa
5 years, 7 months ago (2015-05-19 13:12:13 UTC) #2
Eugene But (OOO till 7-30)
lgtm
5 years, 7 months ago (2015-05-19 16:56:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144873002/1
5 years, 7 months ago (2015-05-19 17:09:38 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/64632)
5 years, 7 months ago (2015-05-19 17:20:32 UTC) #7
lliabraa
+rohitrao for OWNERS
5 years, 7 months ago (2015-05-19 17:50:01 UTC) #9
rohitrao (ping after 24h)
lgtm!
5 years, 7 months ago (2015-05-19 17:59:27 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144873002/1
5 years, 7 months ago (2015-05-19 18:16:11 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-19 18:20:54 UTC) #13
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 18:22:43 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1f113f3df1edef7c130691e5a36b65b95ff95eff
Cr-Commit-Position: refs/heads/master@{#330562}

Powered by Google App Engine
This is Rietveld 408576698