Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1144843002: Mojo service implementation for HTTP server - part 3 (Closed)

Created:
5 years, 7 months ago by yzshen1
Modified:
5 years, 7 months ago
Reviewers:
jam
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, msw
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo service implementation for HTTP server - part 3 This CL adds WebSocket support and correspnoding tests. BUG=478249 TEST=Newly added tests. Committed: https://crrev.com/533f527697b337b7f0300c466bc071d858e3b865 Cr-Commit-Position: refs/heads/master@{#330884}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : clean up #

Patch Set 5 : rebase & resolve #

Unified diffs Side-by-side diffs Delta from patch set Stats (+447 lines, -33 lines) Patch
M mojo/services/network/http_connection_impl.h View 1 2 3 chunks +17 lines, -6 lines 0 comments Download
M mojo/services/network/http_connection_impl.cc View 1 2 3 4 9 chunks +208 lines, -20 lines 0 comments Download
M mojo/services/network/http_server_apptest.cc View 1 2 3 4 10 chunks +215 lines, -7 lines 0 comments Download
M mojo/services/network/public/interfaces/http_connection.mojom View 1 2 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
yzshen1
Hi, John. Would you please take a look? Thanks! This should be the last major ...
5 years, 7 months ago (2015-05-20 21:04:55 UTC) #2
jam
lgtm
5 years, 7 months ago (2015-05-21 01:07:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144843002/80001
5 years, 7 months ago (2015-05-21 01:25:17 UTC) #5
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 7 months ago (2015-05-21 04:35:52 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-21 04:41:03 UTC) #7
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/533f527697b337b7f0300c466bc071d858e3b865
Cr-Commit-Position: refs/heads/master@{#330884}

Powered by Google App Engine
This is Rietveld 408576698