Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1144803002: [iOS] Upstream switches and flags controlling which WebView is used (Closed)

Created:
5 years, 7 months ago by sdefresne
Modified:
5 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[iOS] Upstream switches and flags controlling which WebView is used Which of UIWebView and WKWebView to use can be controller by command line flags, finch and availability (iOS version). BUG=429756 Committed: https://crrev.com/b53a987a83e2d5ce48de50363cd8202a644d6303 Cr-Commit-Position: refs/heads/master@{#330383}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -1 line) Patch
M ios/chrome/browser/chrome_switches.h View 1 chunk +2 lines, -1 line 0 comments Download
M ios/chrome/browser/chrome_switches.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M ios/chrome/browser/experimental_flags.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ios/chrome/browser/experimental_flags.mm View 2 chunks +24 lines, -0 lines 0 comments Download
A ios/chrome/browser/web/web_view_type_util.h View 1 chunk +20 lines, -0 lines 0 comments Download
A ios/chrome/browser/web/web_view_type_util.mm View 1 chunk +16 lines, -0 lines 0 comments Download
M ios/chrome/ios_chrome.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sdefresne
Please take a look.
5 years, 7 months ago (2015-05-18 16:13:27 UTC) #2
Eugene But (OOO till 7-30)
lgtm
5 years, 7 months ago (2015-05-18 16:47:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144803002/1
5 years, 7 months ago (2015-05-18 16:51:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-18 20:02:05 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 22:40:59 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b53a987a83e2d5ce48de50363cd8202a644d6303
Cr-Commit-Position: refs/heads/master@{#330383}

Powered by Google App Engine
This is Rietveld 408576698