Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Unified Diff: PRESUBMIT.py

Issue 11448014: Add a presubmit check to prevent committing .rej/.orig patch files (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | PRESUBMIT_test.py » ('j') | PRESUBMIT_test.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 3b8669ad4b8f6d87f21720d66477f613c14f0b0a..dec08f7b1171e78863d7b6ac0a57d004bd5e2a59 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -689,6 +689,7 @@ def _CommonChecks(input_api, output_api):
results.extend(_CheckNoAuraWindowPropertyHInHeaders(input_api, output_api))
results.extend(_CheckIncludeOrder(input_api, output_api))
results.extend(_CheckForVersionControlConflicts(input_api, output_api))
+ results.extend(_CheckPatchFiles(input_api, output_api))
if any('PRESUBMIT.py' == f.LocalPath() for f in input_api.AffectedFiles()):
results.extend(input_api.canned_checks.RunUnitTestsInDirectory(
@@ -772,6 +773,17 @@ def _CheckAuthorizedAuthor(input_api, output_api):
return []
+def _CheckPatchFiles(input_api, output_api):
+ if_patch_file = input_api.re.compile(r'.*\.(rej|orig)$')
+ problems = [f.LocalPath() for f in input_api.AffectedFiles() if
+ if_patch_file.match(f.LocalPath())]
M-A Ruel 2012/12/05 19:30:17 if f.LocalPath().endswith(('.orig', '.rej')) is cl
+ if problems:
+ return [output_api.PresubmitError(
+ "Don't commit .rej and .orig files.", problems)]
+ else:
+ return []
+
+
def CheckChangeOnUpload(input_api, output_api):
results = []
results.extend(_CommonChecks(input_api, output_api))
« no previous file with comments | « no previous file | PRESUBMIT_test.py » ('j') | PRESUBMIT_test.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698