Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1570)

Unified Diff: cc/layer_tree_host_impl_unittest.cc

Issue 11447028: cc: Split out calcDrawEtc from drawLayers (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Clean up unnecessary test changes Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/layer_tree_host_impl_unittest.cc
diff --git a/cc/layer_tree_host_impl_unittest.cc b/cc/layer_tree_host_impl_unittest.cc
index 84939bc79568acace54605be588bc3b31566ac4f..9ebe327a98b6c112f06ae083c13d3c052a66dfc4 100644
--- a/cc/layer_tree_host_impl_unittest.cc
+++ b/cc/layer_tree_host_impl_unittest.cc
@@ -1932,7 +1932,6 @@ TEST_P(LayerTreeHostImplTest, viewportCovered)
LayerTreeHostImpl::FrameData frame;
EXPECT_TRUE(m_hostImpl->prepareToDraw(frame));
ASSERT_EQ(1u, frame.renderPasses.size());
- m_hostImpl->didDrawAllLayers(frame);
danakj 2012/12/06 19:12:10 don't we need this to avoid "in between willdraw a
enne (OOO) 2012/12/06 19:25:42 You shouldn't call didDrawAllLayers twice. See li
danakj 2012/12/06 19:32:20 Ah!
size_t numGutterQuads = 0;
for (size_t i = 0; i < frame.renderPasses[0]->quad_list.size(); ++i)
@@ -2841,7 +2840,6 @@ TEST_P(LayerTreeHostImplTest, dontUseOldResourcesAfterLostContext)
videoLayer->setAnchorPoint(gfx::PointF(0, 0));
videoLayer->setContentBounds(gfx::Size(10, 10));
videoLayer->setDrawsContent(true);
- videoLayer->setLayerTreeHostImpl(m_hostImpl.get());
rootLayer->addChild(videoLayer.PassAs<LayerImpl>());
FakeVideoFrameProvider providerScaled;
@@ -2850,7 +2848,6 @@ TEST_P(LayerTreeHostImplTest, dontUseOldResourcesAfterLostContext)
videoLayerScaled->setAnchorPoint(gfx::PointF(0, 0));
videoLayerScaled->setContentBounds(gfx::Size(10, 10));
videoLayerScaled->setDrawsContent(true);
- videoLayerScaled->setLayerTreeHostImpl(m_hostImpl.get());
rootLayer->addChild(videoLayerScaled.PassAs<LayerImpl>());
FakeVideoFrameProvider hwProvider;
@@ -2859,7 +2856,6 @@ TEST_P(LayerTreeHostImplTest, dontUseOldResourcesAfterLostContext)
hwVideoLayer->setAnchorPoint(gfx::PointF(0, 0));
hwVideoLayer->setContentBounds(gfx::Size(10, 10));
hwVideoLayer->setDrawsContent(true);
- hwVideoLayer->setLayerTreeHostImpl(m_hostImpl.get());
rootLayer->addChild(hwVideoLayer.PassAs<LayerImpl>());
scoped_ptr<IOSurfaceLayerImpl> ioSurfaceLayer = IOSurfaceLayerImpl::create(layerId++);
@@ -2868,7 +2864,6 @@ TEST_P(LayerTreeHostImplTest, dontUseOldResourcesAfterLostContext)
ioSurfaceLayer->setContentBounds(gfx::Size(10, 10));
ioSurfaceLayer->setDrawsContent(true);
ioSurfaceLayer->setIOSurfaceProperties(1, gfx::Size(10, 10));
- ioSurfaceLayer->setLayerTreeHostImpl(m_hostImpl.get());
rootLayer->addChild(ioSurfaceLayer.PassAs<LayerImpl>());
scoped_ptr<HeadsUpDisplayLayerImpl> hudLayer = HeadsUpDisplayLayerImpl::create(layerId++);
@@ -2876,14 +2871,12 @@ TEST_P(LayerTreeHostImplTest, dontUseOldResourcesAfterLostContext)
hudLayer->setAnchorPoint(gfx::PointF(0, 0));
hudLayer->setContentBounds(gfx::Size(10, 10));
hudLayer->setDrawsContent(true);
- hudLayer->setLayerTreeHostImpl(m_hostImpl.get());
rootLayer->addChild(hudLayer.PassAs<LayerImpl>());
scoped_ptr<FakeScrollbarLayerImpl> scrollbarLayer(FakeScrollbarLayerImpl::create(layerId++));
scrollbarLayer->setBounds(gfx::Size(10, 10));
scrollbarLayer->setContentBounds(gfx::Size(10, 10));
scrollbarLayer->setDrawsContent(true);
- scrollbarLayer->setLayerTreeHostImpl(m_hostImpl.get());
scrollbarLayer->createResources(m_hostImpl->resourceProvider());
rootLayer->addChild(scrollbarLayer.PassAs<LayerImpl>());
@@ -2891,7 +2884,6 @@ TEST_P(LayerTreeHostImplTest, dontUseOldResourcesAfterLostContext)
delegatedRendererLayer->setBounds(gfx::Size(10, 10));
delegatedRendererLayer->setContentBounds(gfx::Size(10, 10));
delegatedRendererLayer->setDrawsContent(true);
- delegatedRendererLayer->setLayerTreeHostImpl(m_hostImpl.get());
ScopedPtrVector<RenderPass> passList;
passList.append(createRenderPassWithResource(m_hostImpl->resourceProvider()));
delegatedRendererLayer->setRenderPasses(passList);
@@ -3035,7 +3027,6 @@ TEST_P(LayerTreeHostImplTest, layersFreeTextures)
videoLayer->setAnchorPoint(gfx::PointF(0, 0));
videoLayer->setContentBounds(gfx::Size(10, 10));
videoLayer->setDrawsContent(true);
- videoLayer->setLayerTreeHostImpl(m_hostImpl.get());
rootLayer->addChild(videoLayer.PassAs<LayerImpl>());
scoped_ptr<IOSurfaceLayerImpl> ioSurfaceLayer = IOSurfaceLayerImpl::create(5);
@@ -3044,7 +3035,6 @@ TEST_P(LayerTreeHostImplTest, layersFreeTextures)
ioSurfaceLayer->setContentBounds(gfx::Size(10, 10));
ioSurfaceLayer->setDrawsContent(true);
ioSurfaceLayer->setIOSurfaceProperties(1, gfx::Size(10, 10));
- ioSurfaceLayer->setLayerTreeHostImpl(m_hostImpl.get());
rootLayer->addChild(ioSurfaceLayer.PassAs<LayerImpl>());
// Lose the context, replacing it with a TrackingWebGraphicsContext3D (which the LayerTreeHostImpl takes ownership of).

Powered by Google App Engine
This is Rietveld 408576698