cc: Split out calcDrawEtc from drawLayers

cc/layer_impl.h

 // Copyright 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CC_LAYER_IMPL_H_
 #define CC_LAYER_IMPL_H_
 
 #include <public/WebFilterOperations.h>
 #include <string>
 
@@ skipping 60 matching lines @@
 
     void setReplicaLayer(scoped_ptr<LayerImpl>);
     LayerImpl* replicaLayer() { return m_replicaLayer.get(); }
     const LayerImpl* replicaLayer() const { return m_replicaLayer.get(); }
 
     bool hasMask() const { return m_maskLayer; }
     bool hasReplica() const { return m_replicaLayer; }
     bool replicaHasMask() const { return m_replicaLayer && (m_maskLayer || m_replicaLayer->m_maskLayer); }
 
     LayerTreeHostImpl* layerTreeHostImpl() const { return m_layerTreeHostImpl; }
-    void setLayerTreeHostImpl(LayerTreeHostImpl* hostImpl) { m_layerTreeHostImpl = hostImpl; }
+    void setLayerTreeHostImpl(LayerTreeHostImpl* hostImpl);
 
     scoped_ptr<SharedQuadState> createSharedQuadState() const;
     // willDraw must be called before appendQuads. If willDraw is called,
     // didDraw is guaranteed to be called before another willDraw or before
     // the layer is destroyed. To enforce this, any class that overrides
     // willDraw/didDraw must call the base class version.
     virtual void willDraw(ResourceProvider*);
     virtual void appendQuads(QuadSink&, AppendQuadsData&) { }
     virtual void didDraw(ResourceProvider*);
 
@@ skipping 62 matching lines @@
 
     void setSublayerTransform(const gfx::Transform&);
     const gfx::Transform& sublayerTransform() const { return m_sublayerTransform; }
 
     // Debug layer name.
     void setDebugName(const std::string& debugName) { m_debugName = debugName; }
     std::string debugName() const { return m_debugName; }
 
     bool showDebugBorders() const;
 
+    // Creating and destroying render surfaces should only be performed by

[danakj, 2012/12/06 19:12:10]

I'm not sure about the destroying part here? Won't they be destroyed during tree
sync if the layer is destroyed, etc?

[enne (OOO), 2012/12/06 19:25:42]

So, here's my thought process.  Setting a draw property should not
setNeedsUpdateDrawProperties(); only setting non-derived properties should cause
that.

More importantly, destroying/creating a render surface invalidates the RSLL
which is now held between frames, and really only the host can manage that. 
I'll update this comment to be more accurate that the caller is responsible for
calling setNeedsUpdateDrawProperties.

+    // calcDrawProperties.
     void createRenderSurface();
     void clearRenderSurface() { m_drawProperties.render_surface.reset(); }
 
     DrawProperties<LayerImpl, RenderSurfaceImpl>& drawProperties() { return m_drawProperties; }
     const DrawProperties<LayerImpl, RenderSurfaceImpl>& drawProperties() const { return m_drawProperties; }
 
     // The following are shortcut accessors to get various information from m_drawProperties
     const gfx::Transform& drawTransform() const { return m_drawProperties.target_space_transform; }
     const gfx::Transform& screenSpaceTransform() const { return m_drawProperties.screen_space_transform; }
     float drawOpacity() const { return m_drawProperties.opacity; }
@@ skipping 114 matching lines @@
     void appendDebugBorderQuad(QuadSink&, const SharedQuadState*, AppendQuadsData&) const;
 
     virtual void dumpLayerProperties(std::string*, int indent) const;
     static std::string indentString(int indent);
 
 private:
     void setParent(LayerImpl* parent) { m_parent = parent; }
     friend class TreeSynchronizer;
     void clearChildList(); // Warning: This does not preserve tree structure invariants and so is only exposed to the tree synchronizer.
 
+    void noteLayerSurfacePropertyChanged();
+    void noteLayerPropertyChanged();
     void noteLayerPropertyChangedForSubtree();
 
     // Note carefully this does not affect the current layer.
     void noteLayerPropertyChangedForDescendants();
 
     virtual const char* layerTypeAsString() const;
 
     void dumpLayer(std::string*, int indent) const;
 
     // Properties internal to LayerImpl
@@ skipping 89 matching lines @@
     DrawProperties<LayerImpl, RenderSurfaceImpl> m_drawProperties;
 
     DISALLOW_COPY_AND_ASSIGN(LayerImpl);
 };
 
 void sortLayers(std::vector<LayerImpl*>::iterator first, std::vector<LayerImpl*>::iterator end, LayerSorter*);
 
 }
 
 #endif  // CC_LAYER_IMPL_H_