Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1012)

Unified Diff: sdk/lib/html/scripts/htmlrenamer.py

Issue 11447002: Re-trying moving AudioElement back to dart:html. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fixing for dartium. Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/html/dartium/html_dartium.dart ('k') | sdk/lib/html/scripts/idlnode.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/html/scripts/htmlrenamer.py
diff --git a/sdk/lib/html/scripts/htmlrenamer.py b/sdk/lib/html/scripts/htmlrenamer.py
index 825d6d55f932d4e18d73f0416ec2342b6905c04e..c55075bf105a95bc2a88d1161b9232777abc4b51 100644
--- a/sdk/lib/html/scripts/htmlrenamer.py
+++ b/sdk/lib/html/scripts/htmlrenamer.py
@@ -361,8 +361,15 @@ class HtmlRenamer(object):
return member_name
def GetLibraryName(self, interface):
+ if 'Conditional' in interface.ext_attrs:
+ if 'WEB_AUDIO' in interface.ext_attrs['Conditional']:
+ return 'web_audio'
+ if 'SVG' in interface.ext_attrs['Conditional']:
+ return 'svg'
+
return self._GetLibraryName(interface.id)
+ # TODO(blois): remove this method when all members are renamed.
def _GetLibraryName(self, idl_type_name):
"""
Gets the name of the library this type should live in.
@@ -370,14 +377,6 @@ class HtmlRenamer(object):
"""
if idl_type_name.startswith('SVG'):
return 'svg'
- if 'Audio' in idl_type_name:
- return 'web_audio'
-
- if self._database.HasInterface(idl_type_name):
- interface = self._database.GetInterface(idl_type_name)
- for parent in self._database.Hierarchy(interface):
- if parent.id == 'AudioNode':
- return 'web_audio'
return 'html'
« no previous file with comments | « sdk/lib/html/dartium/html_dartium.dart ('k') | sdk/lib/html/scripts/idlnode.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698