Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 1144683002: Merge to XFA: Abort on OOM by default in FX_Alloc(). (Closed)

Created:
5 years, 7 months ago by Tom Sepez
Modified:
5 years, 7 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Suppress failing tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -27 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M core/include/fxcrt/fx_memory.h View 2 chunks +46 lines, -9 lines 0 comments Download
M core/include/fxcrt/fx_system.h View 2 chunks +13 lines, -3 lines 0 comments Download
M core/src/fxcodec/codec/fx_codec.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/lbmp/fx_bmp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/lgif/fx_gif.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcrt/fx_basic_memmgr.cpp View 2 chunks +9 lines, -6 lines 0 comments Download
A core/src/fxcrt/fx_basic_memmgr_unittest.cpp View 1 1 chunk +63 lines, -0 lines 0 comments Download
M core/src/fxge/dib/fx_dib_convert.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/dib/fx_dib_engine.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M core/src/fxge/dib/fx_dib_main.cpp View 1 chunk +1 line, -1 line 0 comments Download
M pdfium.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Tom Sepez
TBR'd.
5 years, 7 months ago (2015-05-15 22:15:56 UTC) #1
Lei Zhang
lgtm
5 years, 7 months ago (2015-05-15 22:18:34 UTC) #2
Tom Sepez
5 years, 7 months ago (2015-05-15 23:30:56 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
ed099befbb300d6f9c393cb415fdb2a68c2ef471 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698