Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Issue 1144673003: Fix and cleanup Mojo and Mandoline python scripts. (Closed)

Created:
5 years, 7 months ago by msw
Modified:
5 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix and cleanup Mojo and Mandoline python scripts. Simplify the Config class and consolidate init logic. Inline GN argument file parsing and make it optional. Take an optional build_dir argument for Paths use. Simplify the Paths class; respect Config's build_dir. Only reconstruct build_dir if Config doesn't have one. Remove unused methods; rename mojo_runner path member. Remove unused GN utilities and dart apptest support. BUG=486220, 488128 TEST=android_run_mandoline.py, android_mojo_shell.py, and apptest_runner.py work as expected. R=sky@chromium.org Committed: https://crrev.com/6c8ec83b6163f32361ca742e91189969f759ed7f Cr-Commit-Position: refs/heads/master@{#330391}

Patch Set 1 #

Patch Set 2 : Remove unused dart apptest support. #

Patch Set 3 : Update comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -314 lines) Patch
M mandoline/tools/android_run_mandoline.py View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/tools/android_mojo_shell.py View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/tools/apptest_runner.py View 1 4 chunks +5 lines, -14 lines 0 comments Download
M mojo/tools/data/apptests View 1 1 chunk +0 lines, -1 line 0 comments Download
M mojo/tools/mopy/config.py View 1 2 4 chunks +58 lines, -65 lines 0 comments Download
D mojo/tools/mopy/dart_apptest.py View 1 1 chunk +0 lines, -38 lines 0 comments Download
D mojo/tools/mopy/gn.py View 1 chunk +0 lines, -141 lines 0 comments Download
M mojo/tools/mopy/gtest.py View 1 1 chunk +1 line, -2 lines 0 comments Download
M mojo/tools/mopy/paths.py View 2 chunks +24 lines, -44 lines 0 comments Download
M mojo/tools/mopy/test_util.py View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
msw
Hey Scott, please take a look; thanks!
5 years, 7 months ago (2015-05-15 23:00:21 UTC) #2
sky
LGTM
5 years, 7 months ago (2015-05-18 17:05:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144673003/40001
5 years, 7 months ago (2015-05-18 17:55:15 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-18 20:16:41 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 22:41:30 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6c8ec83b6163f32361ca742e91189969f759ed7f
Cr-Commit-Position: refs/heads/master@{#330391}

Powered by Google App Engine
This is Rietveld 408576698