Reland: Roll src/third_party/libsrtp 6446144:9c53f85 (svn 292694:295151)

Reland: Roll src/third_party/libsrtp 6446144:9c53f85 (svn 292694:295151)

This updates libsrtp to 1.5.2 and uses the OpenSSL/BoringSSL crypto code.
See https://codereview.chromium.org/889083003/ and https://codereview.chromium.org/1098043003/

Summary of changes available at:
https://chromium.googlesource.com/chromium/deps/libsrtp/+log/6446144..9c53f85

This previously landed in https://codereview.chromium.org/1130413005/ but got
reverted in https://codereview.chromium.org/1139233002/ as it broke the Chrome
Linux x64 builds due to a added dependency to "libgcc_s.so.1(GCC_3.0)(64bit)".
The dependency was already allowed for 32bit, so it is allowed for 64bit now,
too.

BUG=328475
Committed: https://crrev.com/c6d10bdd0fee0aee8aa6143c8501c6c382704b9b
Cr-Commit-Position: refs/heads/master@{#330209}

[joachim, 2015-05-15 11:31:20]

jbauch@webrtc.org changed reviewers:
+ jiayl@chromium.org, juberti@chromium.org, phajdan.jr@chromium.org,
thakis@chromium.org

[joachim, 2015-05-15 11:32:24]

jbauch@webrtc.org changed reviewers:
+ jbauch@webrtc.org

[joachim, 2015-05-15 11:32:25]

ptal

[Nico, 2015-05-15 13:15:50]

On 2015/05/15 11:32:25, joachim wrote:
> ptal

What symbol is the dependency needed for?

[joachim, 2015-05-15 13:26:56]

On 2015/05/15 13:15:50, Nico wrote:
> What symbol is the dependency needed for?

I don't know (yet). The external library dependencies didn't change, so this is
pulled in implicitly by the compiler/linker somehow.

I'm currently rebasing/rebuilding Chromium and check if I find something. Afaik
I have no way to reproduce/test this locally in an official Chrome build as that
seems to require stuff from internal repositories.

[joachim, 2015-05-15 13:30:17]

On 2015/05/15 13:26:56, joachim wrote:
> On 2015/05/15 13:15:50, Nico wrote:
> > What symbol is the dependency needed for?
> 
> I don't know (yet). The external library dependencies didn't change, so this
is
> pulled in implicitly by the compiler/linker somehow.
> 
> I'm currently rebasing/rebuilding Chromium and check if I find something.
Afaik
> I have no way to reproduce/test this locally in an official Chrome build as
that
> seems to require stuff from internal repositories.

Btw, you added the dependency for 32bit in
crrev.com/bec7f1c6c800de888692696826a767d86565ab95, so for some reason it was
already required for 32bit, but not for 64bit at that time.

[joachim, 2015-05-15 17:01:04]

If we don't want to add the dependency to the 64bit whitelist, I think I'll
need some help on this as I can't figure out why the dependency is now pulled
in with the update.

Do you have any recommendations on how to find out which symbol is imported
from a library on Ubuntu/Linux or know somebody who could help me get this
landed?

[Nico, 2015-05-15 17:06:13]

thakis@chromium.org changed reviewers:
+ thestig@chromium.org

[Nico, 2015-05-15 17:06:13]

I think adding this is probably fine. Lei, does this look ok to you?

[Lei Zhang, 2015-05-15 19:39:41]

On 2015/05/15 17:06:13, Nico wrote:
> I think adding this is probably fine. Lei, does this look ok to you?

Ya, the Linux installer expectations update is fine.

[Nico, 2015-05-15 19:40:30]

lgtm then

[joachim, 2015-05-15 19:41:55]

On 2015/05/15 19:40:30, Nico wrote:
> lgtm then

Thanks, is there a trybot I could trigger to test this before submitting to CQ?

[Nico, 2015-05-15 19:43:19]

I don't think so :-(

On Fri, May 15, 2015 at 12:41 PM, <jbauch@webrtc.org> wrote:

> On 2015/05/15 19:40:30, Nico wrote:
>
>> lgtm then
>>
>
> Thanks, is there a trybot I could trigger to test this before submitting
> to CQ?
>
> https://codereview.chromium.org/1144623002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[joachim, 2015-05-15 19:43:43]

The CQ bit was checked by jbauch@webrtc.org

[commit-bot: I haz the power, 2015-05-15 19:44:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1144623002/1

[joachim, 2015-05-15 19:55:55]

On 2015/05/15 19:39:41, Lei Zhang wrote:
> Ya, the Linux installer expectations update is fine.

I think I will need an explicit l-g-t-m to make the presubmit check happy:
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...

Thanks :)

[commit-bot: I haz the power, 2015-05-15 19:56:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-15 19:56:57]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Nico, 2015-05-15 19:58:30]

chrome/installer/linux/OWNERS has noparents :-/ We should probably remove that.

thestig, can you stamp please?

[Lei Zhang, 2015-05-15 20:29:13]

lgtm

[joachim, 2015-05-15 20:29:59]

The CQ bit was checked by jbauch@webrtc.org

[Lei Zhang, 2015-05-15 20:30:15]

On 2015/05/15 19:58:30, Nico wrote:
> chrome/installer/linux/OWNERS has noparents :-/ We should probably remove
that.
> 
> thestig, can you stamp please?

We are somewhat paranoid about accidentally adding new package dependencies.

[commit-bot: I haz the power, 2015-05-15 20:31:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1144623002/1

[commit-bot: I haz the power, 2015-05-15 21:59:56]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-05-18 11:28:06]

Patchset 1 (id:??) landed as
https://crrev.com/c6d10bdd0fee0aee8aa6143c8501c6c382704b9b
Cr-Commit-Position: refs/heads/master@{#330209}