Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 11446078: Add suport for changing cursors (Closed)

Created:
8 years ago by cpu_(ooo_6.6-7.5)
Modified:
8 years ago
CC:
chromium-reviews, ben+watch_chromium.org
Visibility:
Public.

Description

Win8 Aura :add suport for changing cursors To change the cursor we need to send a message from the browser to the viewer with the right HCURSOR. Since the cursors are a GDI shared resource, we can call ::LoadCursor in the browser and ::SetCursor in the viewer. BUG=151718 TEST= moving pointer to a chrome window edge changes cursor to resize cursor Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=172265

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -3 lines) Patch
M ui/aura/remote_root_window_host_win.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/metro_viewer/metro_viewer_messages.h View 1 2 chunks +7 lines, -1 line 0 comments Download
M win8/metro_driver/chrome_app_view_ash.h View 1 chunk +2 lines, -0 lines 0 comments Download
M win8/metro_driver/chrome_app_view_ash.cc View 4 chunks +25 lines, -2 lines 1 comment Download

Messages

Total messages: 7 (0 generated)
cpu_(ooo_6.6-7.5)
ben, please review : ui/aura/remote_root_window_host_win.cc ananta: the rest.
8 years ago (2012-12-08 01:55:53 UTC) #1
ananta
lgtm https://codereview.chromium.org/11446078/diff/5001/win8/metro_driver/chrome_app_view_ash.cc File win8/metro_driver/chrome_app_view_ash.cc (right): https://codereview.chromium.org/11446078/diff/5001/win8/metro_driver/chrome_app_view_ash.cc#newcode365 win8/metro_driver/chrome_app_view_ash.cc:365: ::SetCursor(HCURSOR(cursor)); replace with cursor
8 years ago (2012-12-11 00:17:30 UTC) #2
cpu_(ooo_6.6-7.5)
cdn, please review metro_viewer_messages.h
8 years ago (2012-12-11 01:21:37 UTC) #3
Ben Goodger (Google)
lgtm how do we do custom cursors?
8 years ago (2012-12-11 01:23:16 UTC) #4
cpu_(ooo_6.6-7.5)
Not sure, I need to test, the theory indicates that this change works for them ...
8 years ago (2012-12-11 04:31:34 UTC) #5
Cris Neckar
lgtm
8 years ago (2012-12-11 18:39:00 UTC) #6
sadrul
8 years ago (2012-12-11 18:41:33 UTC) #7
Message was sent while issue was closed.
On 2012/12/11 01:23:16, Ben Goodger (Google) wrote:
> lgtm
> 
> how do we do custom cursors?

There are a couple of TODOs in webkit/glue/webcursor_aurawin.cc that will need
to be addressed for custom web-cursors, I believe.

Powered by Google App Engine
This is Rietveld 408576698