Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Side by Side Diff: base/shared_memory_android.cc

Issue 11446048: The correct type for the size of a chunk of memory is size_t. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « base/shared_memory.h ('k') | base/shared_memory_nacl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/shared_memory.h" 5 #include "base/shared_memory.h"
6 6
7 #include <sys/mman.h> 7 #include <sys/mman.h>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "third_party/ashmem/ashmem.h" 10 #include "third_party/ashmem/ashmem.h"
11 11
12 namespace base { 12 namespace base {
13 13
14 // For Android, we use ashmem to implement SharedMemory. ashmem_create_region 14 // For Android, we use ashmem to implement SharedMemory. ashmem_create_region
15 // will automatically pin the region. We never explicitly call pin/unpin. When 15 // will automatically pin the region. We never explicitly call pin/unpin. When
16 // all the file descriptors from different processes associated with the region 16 // all the file descriptors from different processes associated with the region
17 // are closed, the memory buffer will go away. 17 // are closed, the memory buffer will go away.
18 18
19 bool SharedMemory::Create(const SharedMemoryCreateOptions& options) { 19 bool SharedMemory::Create(const SharedMemoryCreateOptions& options) {
20 DCHECK_EQ(-1, mapped_file_ ); 20 DCHECK_EQ(-1, mapped_file_ );
21 21
22 if (options.size > static_cast<size_t>(std::numeric_limits<int>::max()))
23 return false;
24
22 // "name" is just a label in ashmem. It is visible in /proc/pid/maps. 25 // "name" is just a label in ashmem. It is visible in /proc/pid/maps.
23 mapped_file_ = ashmem_create_region( 26 mapped_file_ = ashmem_create_region(
24 options.name == NULL ? "" : options.name->c_str(), 27 options.name == NULL ? "" : options.name->c_str(),
25 options.size); 28 options.size);
26 if (-1 == mapped_file_) { 29 if (-1 == mapped_file_) {
27 DLOG(ERROR) << "Shared memory creation failed"; 30 DLOG(ERROR) << "Shared memory creation failed";
28 return false; 31 return false;
29 } 32 }
30 33
31 int err = ashmem_set_prot_region(mapped_file_, 34 int err = ashmem_set_prot_region(mapped_file_,
(...skipping 13 matching lines...) Expand all
45 return true; 48 return true;
46 } 49 }
47 50
48 bool SharedMemory::Open(const std::string& name, bool read_only) { 51 bool SharedMemory::Open(const std::string& name, bool read_only) {
49 // ashmem doesn't support name mapping 52 // ashmem doesn't support name mapping
50 NOTIMPLEMENTED(); 53 NOTIMPLEMENTED();
51 return false; 54 return false;
52 } 55 }
53 56
54 } // namespace base 57 } // namespace base
OLDNEW
« no previous file with comments | « base/shared_memory.h ('k') | base/shared_memory_nacl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698