Make sure that all OpenDevice requests are scrutinized against the audio and video policies.

content/public/common/media_stream_request.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_COMMON_MEDIA_STREAM_REQUEST_H_
 #define CONTENT_PUBLIC_COMMON_MEDIA_STREAM_REQUEST_H_
 
 #include <map>
 #include <string>
 #include <vector>
@@ skipping 12 matching lines @@
   MEDIA_DEVICE_AUDIO_CAPTURE,
   MEDIA_DEVICE_VIDEO_CAPTURE,
 
   // Mirroring of a browser tab.
   MEDIA_TAB_AUDIO_CAPTURE,
   MEDIA_TAB_VIDEO_CAPTURE,
 
   NUM_MEDIA_TYPES
 };
 
+enum MediaStreamRequestType {
+  MEDIA_DEVICE_ACCESS = 0,
+  MEDIA_GENERATE_STREAM,
+  MEDIA_ENUMERATE_DEVICES,
+  MEDIA_OPEN_DEVICE
+};
+
 // Convenience predicates to determine whether the given type represents some
 // audio or some video device.
 CONTENT_EXPORT bool IsAudioMediaType(MediaStreamDeviceType type);
 CONTENT_EXPORT bool IsVideoMediaType(MediaStreamDeviceType type);
 
 // TODO(xians): Change the structs to classes.
 // Represents one device in a request for media stream(s).
 struct CONTENT_EXPORT MediaStreamDevice {
   MediaStreamDevice(
       MediaStreamDeviceType type,
@@ skipping 15 matching lines @@
 typedef std::vector<MediaStreamDevice> MediaStreamDevices;
 
 typedef std::map<MediaStreamDeviceType, MediaStreamDevices>
     MediaStreamDeviceMap;
 
 // Represents a request for media streams (audio/video).
 struct CONTENT_EXPORT MediaStreamRequest {
   MediaStreamRequest(
       int render_process_id,
       int render_view_id,
-      const GURL& security_origin);
+      const GURL& security_origin,
+      MediaStreamRequestType request_type);
 
   ~MediaStreamRequest();
 
   // The render process id generating this request.
   int render_process_id;
 
   // The render view id generating this request.
   int render_view_id;
 
   // The WebKit security origin for the current request (e.g. "html5rocks.com").
   GURL security_origin;
 
+  // Whether the request should be verified against the rules for denial only or

[Jói, 2012/12/12 14:18:18]

It's not clear here what happens for each of the different
MediaStreamRequestType values.  Suggest documenting each of their meanings
above, where the enum is defined.

[pastarmovj, 2012/12/12 14:52:52]

Done.

+  // whether the user should be explicitly asked for permission too.
+  MediaStreamRequestType request_type;
+
   // A list of devices present on the user's computer, for each device type
   // requested.
   // All the elements in this map will be deleted in ~MediaStreamRequest().
   MediaStreamDeviceMap devices;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_COMMON_MEDIA_STREAM_REQUEST_H_