Issue 11446040: Remove stale dependencies on dart2js scripts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11446040: Remove stale dependencies on dart2js scripts. (Closed)

Created:
8 years ago by ahe

Modified:
8 years ago

Reviewers:
kasperl, kustermann

CC:
reviews_dartlang.org, ricow1, dgrove

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Remove stale dependencies on dart2js scripts. Also, add build rule to delete old dart2js scripts. Committed: https://code.google.com/p/dart/source/detail?r=15841

Patch Set 1 #

Total comments: 1

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+55 lines, -4 lines)			Patch
M	dart/dart.gyp	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	dart/utils/apidoc/apidoc.gyp	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	dart/utils/compiler/compiler.gyp	View	1 chunk	+21 lines, -0 lines	0 comments	Download
A	dart/utils/compiler/remove_old_scripts.py	View	1 chunk	+28 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

kustermann

8 years ago (2012-12-06 15:51:39 UTC) #2

LGTM

https://codereview.chromium.org/11446040/diff/1/dart/utils/compiler/remove_ol...
File dart/utils/compiler/remove_old_scripts.py (right):

https://codereview.chromium.org/11446040/diff/1/dart/utils/compiler/remove_ol...
dart/utils/compiler/remove_old_scripts.py:11: python tools/list_files.py
FILE_TO_TOUCH FILES_TO_DELETE...
You should change that to "remove_old_scripts.py".

Expand Messages | Collapse Messages