chrome/renderer/autofill/password_generation_manager.cc - Issue 11446028: Ignore autocomplete=off when password manager is saving the generated passwords during account crea…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/autofill/password_generation_manager.cc

Issue 11446028: Ignore autocomplete=off when password manager is saving the generated passwords during account crea… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address gcasto's comment Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/password_manager/password_manager_unittest.cc ('K') | « chrome/renderer/autofill/password_autofill_manager.cc ('k') | content/public/common/password_form.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/autofill/password_generation_manager.cc

diff --git a/chrome/renderer/autofill/password_generation_manager.cc b/chrome/renderer/autofill/password_generation_manager.cc

index 3e0b52538db8c2323174d47f046472432d735f19..98993849aa3ca0a3b888308e69960141e7ee34fb 100644

--- a/chrome/renderer/autofill/password_generation_manager.cc

+++ b/chrome/renderer/autofill/password_generation_manager.cc

@@ -103,10 +103,7 @@ void PasswordGenerationManager::DidFinishLoad(WebKit::WebFrame* frame) {

WebKit::WebVector<WebKit::WebFormElement> forms;

frame->document().forms(forms);

for (size_t i = 0; i < forms.size(); ++i) {

- // Ignore forms with autocomplete turned off for now. We may remove this in

- // the future, as we only want to avoid creating passwords if the signin

- // form has autocomplete turned off.

- if (forms[i].isNull() || !forms[i].autoComplete())

+ if (forms[i].isNull())

Ilya Sherman 2012/12/06 22:55:59 Please add/update tests to reflect this change, if

zysxqn 2012/12/06 23:54:49 Done.

continue;

// If we can't get a valid PasswordForm, we skip this form because the