Ignore autocomplete=off when password manager is saving the generated passwords during account crea…

content/public/common/password_form.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_COMMON_PASSWORD_FORM_H__
 #define CONTENT_PUBLIC_COMMON_PASSWORD_FORM_H__
 
 #include <map>
 #include <string>
 
@@ skipping 81 matching lines @@
   // The name of the password input element, Optional (improves scoring).
   //
   // When parsing an HTML form, this must always be set.
   string16 password_element;
 
   // The password. Required.
   //
   // When parsing an HTML form, this is typically empty.
   string16 password_value;
 
+  // Whether we should autofill the password based on the autocomplete property
+  // in the password form.
+  bool password_should_autocomplete;

[tim (not reviewing), 2012/12/11 01:23:04]

This makes it sound more authoritative than it is -- maybe
form_autocomplete_attribute_value?

[zysxqn, 2012/12/11 01:52:32]

I can get your point: whether we should autocomplete is not solely determined by
this value, and this just indicates whether the autocomplete property is set to
off or not. But it is convenient to make this property a bool value. How about
naming it to "password_autocomplete_set"?

+
   // If the form was a change password form, the name of the
   // 'old password' input element. Optional.
   string16 old_password_element;
 
   // The old password. Optional.
   string16 old_password_value;
 
   // Whether or not this login was saved under an HTTPS session with a valid
   // SSL cert. We will never match or autofill a PasswordForm where
   // ssl_valid == true with a PasswordForm where ssl_valid == false. This means
@@ skipping 36 matching lines @@
   PasswordForm();
   ~PasswordForm();
 };
 
 // Map username to PasswordForm* for convenience. See password_form_manager.h.
 typedef std::map<string16, PasswordForm*> PasswordFormMap;
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_COMMON_PASSWORD_FORM_H__