[Android] Only invalidate objects that were received from Tango on resume.

chrome/android/javatests/src/org/chromium/chrome/browser/sync/ChromeBrowserSyncAdapterTest.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.sync;
 
 import android.accounts.Account;
 import android.app.Application;
 import android.content.Context;
 import android.content.Intent;
 import android.content.SyncResult;
 import android.os.Bundle;
 import android.test.suitebuilder.annotation.MediumTest;
 
 import org.chromium.base.ApplicationStatus;
 import org.chromium.base.CommandLine;
 import org.chromium.base.test.util.Feature;
 import org.chromium.chrome.browser.ChromeActivity;
 import org.chromium.chrome.test.ChromeActivityTestCaseBase;
+import org.chromium.components.invalidation.PendingInvalidation;
 import org.chromium.content.browser.test.util.Criteria;
 import org.chromium.content.browser.test.util.CriteriaHelper;
 import org.chromium.sync.AndroidSyncSettings;
 import org.chromium.sync.signin.AccountManagerHelper;
 
 /**
  * Tests for ChromeBrowserSyncAdapter.
  *
  * TODO(nyquist) Remove this class when Chrome sync starts up the same way as the testshell.
  */
@@ skipping 17 matching lines @@
 
         assertTrue("Activity should have been sent to background",
                 CriteriaHelper.pollForCriteria(new Criteria() {
                     @Override
                     public boolean isSatisfied() {
                         return !ApplicationStatus.hasVisibleActivities();
                     }
                 }, WAIT_FOR_LAUNCHER_MS, POLL_INTERVAL_MS));
     }
 
+    private void performSyncWithBundle(Bundle bundle) {
+        mSyncAdapter.onPerformSync(TEST_ACCOUNT, bundle,
+                AndroidSyncSettings.getContractAuthority(getActivity()), null, new SyncResult());
+    }
 
     private static class TestChromeSyncAdapter extends ChromiumSyncAdapter {
         private boolean mSyncRequested;
         private boolean mSyncRequestedForAllTypes;
         private int mObjectSource;
         private String mObjectId;
         private long mVersion;
         private String mPayload;
 
         public TestChromeSyncAdapter(Context context, Application application) {
             super(context, application);
         }
 
         @Override
         protected boolean useAsyncStartup() {
             return false;
         }
 
         @Override
-        public void requestSync(int objectSource, String objectId, long version, String payload) {
+        public void notifyInvalidation(
+                int objectSource, String objectId, long version, String payload) {
             mObjectSource = objectSource;
             mObjectId = objectId;
             mVersion = version;
             mPayload = payload;
-            mSyncRequested = true;
-        }
-
-        @Override
-        public void requestSyncForAllTypes() {
-            mSyncRequestedForAllTypes = true;
+            if (objectId == null) {
+                mSyncRequestedForAllTypes = true;
+            } else {
+                mSyncRequested = true;
+            }
         }
     }
 
     @Override
     protected void setUp() throws Exception {
         super.setUp();
         mSyncAdapter = new TestChromeSyncAdapter(getInstrumentation().getTargetContext(),
                 getActivity().getApplication());
     }
 
     @Override
     public void startMainActivity() throws InterruptedException {
         startMainActivityOnBlankPage();
     }
 
     @MediumTest
     @Feature({"Sync"})
     public void testRequestSyncNoInvalidationData() {
-        SyncResult syncResult = new SyncResult();
-        mSyncAdapter.onPerformSync(TEST_ACCOUNT, new Bundle(),
-                AndroidSyncSettings.getContractAuthority(getActivity()), null, syncResult);
+        performSyncWithBundle(new Bundle());
         assertTrue(mSyncAdapter.mSyncRequestedForAllTypes);
         assertFalse(mSyncAdapter.mSyncRequested);
         assertTrue(CommandLine.isInitialized());
     }
 
     @MediumTest
     @Feature({"Sync"})
     public void testRequestSyncSpecificDataType() {
-        SyncResult syncResult = new SyncResult();
-        Bundle extras = new Bundle();
-        extras.putInt(ChromiumSyncAdapter.INVALIDATION_OBJECT_SOURCE_KEY, 65);
-        extras.putString(ChromiumSyncAdapter.INVALIDATION_OBJECT_ID_KEY, "objectid_value");
-        extras.putLong(ChromiumSyncAdapter.INVALIDATION_VERSION_KEY, 42);
-        extras.putString(ChromiumSyncAdapter.INVALIDATION_PAYLOAD_KEY, "payload_value");
-        mSyncAdapter.onPerformSync(TEST_ACCOUNT, extras,
-                AndroidSyncSettings.getContractAuthority(getActivity()), null, syncResult);
+        final String objectId = "objectid_value";

[nyquist, 2015/05/22 20:21:07]

Nit: unnecessary final

[knn, 2015/06/04 18:23:29]

Done.

+        final int objectSource = 65;
+        final long version = 42L;
+        final String payload = "payload_value";
+
+        performSyncWithBundle(
+                new PendingInvalidation(objectId, objectSource, version, payload).toBundle());
+
         assertFalse(mSyncAdapter.mSyncRequestedForAllTypes);
         assertTrue(mSyncAdapter.mSyncRequested);
-        assertEquals(65, mSyncAdapter.mObjectSource);
-        assertEquals("objectid_value", mSyncAdapter.mObjectId);
-        assertEquals(42, mSyncAdapter.mVersion);
-        assertEquals("payload_value", mSyncAdapter.mPayload);
+        assertEquals(objectSource, mSyncAdapter.mObjectSource);
+        assertEquals(objectId, mSyncAdapter.mObjectId);
+        assertEquals(version, mSyncAdapter.mVersion);
+        assertEquals(payload, mSyncAdapter.mPayload);
         assertTrue(CommandLine.isInitialized());
     }
 
     @MediumTest
     @Feature({"Sync"})
     public void testRequestSyncWhenChromeInBackground() throws InterruptedException {
         sendChromeToBackground(getActivity());
-        SyncResult syncResult = new SyncResult();
-        mSyncAdapter.onPerformSync(TEST_ACCOUNT, new Bundle(),
-                AndroidSyncSettings.getContractAuthority(getActivity()), null, syncResult);
+        performSyncWithBundle(new Bundle());
         assertFalse(mSyncAdapter.mSyncRequestedForAllTypes);
         assertFalse(mSyncAdapter.mSyncRequested);
     }
 }