Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Unified Diff: chrome/installer/util/duplicate_tree_detector.cc

Issue 1144543008: Check last modification time on overinstall for all dev builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/duplicate_tree_detector.cc
diff --git a/chrome/installer/util/duplicate_tree_detector.cc b/chrome/installer/util/duplicate_tree_detector.cc
index d52dbcfeff62b8851449295af1a93c41073df144..37d4aeb6125b682f4aebefaff2d3af79247bcf5d 100644
--- a/chrome/installer/util/duplicate_tree_detector.cc
+++ b/chrome/installer/util/duplicate_tree_detector.cc
@@ -23,8 +23,8 @@ bool IsIdenticalFileHierarchy(const base::FilePath& src_path,
if (!src_info.is_directory && !dest_info.is_directory) {
// Two files are "identical" if the file sizes are equivalent.
is_identical = src_info.size == dest_info.size;
-#ifndef NDEBUG
- // For Debug builds, also check last modification time (to make sure
+#if !defined(OFFICIAL_BUILD)
+ // For developer builds, also check last modification time (to make sure
// version dir DLLs are replaced on over-install even if the tested change
// doesn't happen to change a given DLL's size).
if (is_identical)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698